Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 55363003: Send compressed histograms with system logs when sending feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: attachment helper Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index ce46532a126a36e3a9e640ac6a78479ef5e8dcb5..6da1bca009e1757e59e8109a937bb403a3357061 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -107,7 +107,8 @@ bool FeedbackPrivateGetStringsFunction::RunImpl() {
SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);
SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);
SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);
- SET_STRING("sysinfo", IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX);
+ SET_STRING("sys-info",
+ IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX);
SET_STRING("attach-file-label", IDS_FEEDBACK_ATTACH_FILE_LABEL);
SET_STRING("attach-file-note", IDS_FEEDBACK_ATTACH_FILE_NOTE);
SET_STRING("attach-file-to-big", IDS_FEEDBACK_ATTACH_FILE_TO_BIG);
@@ -215,10 +216,17 @@ bool FeedbackPrivateSendFeedbackFunction::RunImpl() {
->GetForProfile(GetProfile())
->GetService();
DCHECK(service);
+
+ if (feedback_info.send_histograms) {
rkc 2013/11/01 19:57:39 As mentioned in the IDL, this could just be a chec
+ scoped_ptr<std::string> histograms(service->GetHistograms());
+ feedback_data->SetAndCompressHistograms(*histograms);
+ }
+
service->SendFeedback(
GetProfile(),
feedback_data,
base::Bind(&FeedbackPrivateSendFeedbackFunction::OnCompleted, this));
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698