Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service.h

Issue 55363003: Send compressed histograms with system logs when sending feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed feedback feedback Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_service.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.h b/chrome/browser/extensions/api/feedback_private/feedback_service.h
index 1bb85bffdf096261aaeee7d0bc0502094997acad..5c29dd21817337b5a32243a10d9a698173d3c6c3 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_service.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.h
@@ -44,7 +44,7 @@ class FeedbackService {
const SendFeedbackCallback& callback);
// Platform specific methods:
- // Get's the email address of the logged in user.
+ // Gets the email address of the logged in user.
virtual std::string GetUserEmail() = 0;
// Start to gather system information.
@@ -52,6 +52,9 @@ class FeedbackService {
virtual void GetSystemInformation(
const GetSystemInformationCallback& callback) = 0;
+ // Gets the histograms in JSON.
+ virtual scoped_ptr<std::string> GetHistograms() = 0;
+
protected:
FeedbackService();

Powered by Google App Engine
This is Rietveld 408576698