Send compressed histograms with system logs when sending feedback.

chrome/common/extensions/api/feedback_private.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.feedbackPrivate</code> API to provide Chrome [OS]
 // feedback to the Google Feedback servers.
 namespace feedbackPrivate {
 
   dictionary AttachedFile {
     DOMString name;
@@ skipping 29 matching lines @@
     [instanceOf=Blob] object? screenshot;
 
     // Optional id for performance trace data that can be included in this
     // report.
     long? traceId;
 
     // An array of key/value pairs providing system information for this
     // feedback report.
     SystemInformation[]? systemInformation;
 
+    // True if we have permission to add histograms to this feedback report.
+    boolean sendHistograms;

[rkc, 2013/11/01 19:57:39]

I would rather not modify the .idl for this. We can instead add a canary field
to the system information itself like,
"sendHistograms: 'true'"

Then in the sendFeedback implementation, check if that field exists in system
information, if so, remove it from system information and attach the histograms.

(In fact, later we should move the traceId field also out of this idl and find a
cleaner solution for these extra payloads for the feedback report - but that is
a separate task that isn't in the scope of this CL).

[michaelpg, 2013/11/01 22:14:50]

As we discussed we'll keep this in the .idl for now along with traceId.

+
     // TODO(rkc): Remove these once we have bindings to send blobs to Chrome.
     // Used internally to store the blob uuid after parameter customization.
     DOMString? attachedFileBlobUuid;
     DOMString? screenshotBlobUuid;
   };
 
   // Status of the sending of a feedback report.
   enum Status {success, delayed};
 
   callback GetUserEmailCallback = void(DOMString email);
@@ skipping 20 matching lines @@
   };
 
   interface Events {
     // Fired when the a user requests the launch of the feedback UI. We're
     // using an event for this versus using the override API since we want
     // to be invoked, but not showing a UI, so the feedback extension can
     // take a screenshot of the user's desktop.
     static void onFeedbackRequested(FeedbackInfo feedback);
   };
 };