src/harmony-array-includes.js - Issue 553623004: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/harmony-array-includes.js

Issue 553623004: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove failing tests. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/harmony-array-includes.js

diff --git a/src/harmony-array-includes.js b/src/harmony-array-includes.js

index d1a779042135b4d586031ea091b39bc6196078bf..d48e797b8b32c0e1c0365331b47c6f4abe17756a 100644

--- a/src/harmony-array-includes.js

+++ b/src/harmony-array-includes.js

@@ -52,6 +52,9 @@ function HarmonyArrayIncludesExtendArrayPrototype() {

%FunctionSetLength(ArrayIncludes, 1);

+ // Upgrade index conversion semantics to ES6.

+ ToLength.harmony = true;

// Set up the non-enumerable functions on the Array prototype object.

InstallFunctions($Array.prototype, DONT_ENUM, $Array(

"includes", ArrayIncludes

« no previous file with comments | « src/harmony-array.js ('k') | src/harmony-templates.js » ('j') | no next file with comments »