fpdfsdk/src/fpdfppo.cpp - Issue 553613003: Check the validity of pointers before they are utilized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfppo.cpp

Issue 553613003: Check the validity of pointers before they are utilized (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfppo.cpp

diff --git a/fpdfsdk/src/fpdfppo.cpp b/fpdfsdk/src/fpdfppo.cpp

index b8d2125b7dab667e0e0d9d50aa708474309757b6..6e9a194084920efa27507fa7143b93bbfe091277 100644

--- a/fpdfsdk/src/fpdfppo.cpp

+++ b/fpdfsdk/src/fpdfppo.cpp

@@ -313,9 +313,17 @@ int CPDF_PageOrganizer::GetNewObjId(CPDF_Document *pDoc, CFX_MapPtrToPtr* pMapPt

}

else

{

- CPDF_Object* pClone = pRef->GetDirect()->Clone();

- if(!pClone)

+ CPDF_Object* pDirect = pRef->GetDirect();

+ if(!pDirect)

+ {

+ return 0;

+ }

+ CPDF_Object* pClone = pDirect->Clone();

Tom Sepez 2014/09/08 17:58:34 nit: stray space before equals.

+ if(!pClone)

+ {

return 0;

+ }

if(pClone->GetType() == PDFOBJ_DICTIONARY)

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »