Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 553613003: Check the validity of pointers before they are utilized (Closed)

Created:
6 years, 3 months ago by jun_fang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, Bo Xu
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

The cause of this issue is that there is an indirect object like '112 0 R' but no its direct object '112 0 object' in the test pdf file. Without checking the validity, it causes a null pointer when trying to get the direct object by an indirect object. BUG=390781 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4cf36954a1676e103f899bee0138610c76500b42

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M fpdfsdk/src/fpdfppo.cpp View 1 2 3 4 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Bo Xu
On 2014/09/07 09:33:27, jun_fang wrote: > mailto:jun_fang@foxitsoftware.com changed reviewers: > + mailto:bo_xu@foxitsoftware.com, mailto:tsepez@chromium.org Should add ...
6 years, 3 months ago (2014-09-08 00:47:26 UTC) #2
Bo Xu
https://codereview.chromium.org/553613003/diff/1/fpdfsdk/src/fpdfppo.cpp File fpdfsdk/src/fpdfppo.cpp (right): https://codereview.chromium.org/553613003/diff/1/fpdfsdk/src/fpdfppo.cpp#newcode317 fpdfsdk/src/fpdfppo.cpp:317: if (pRef) { No need to check pRef since ...
6 years, 3 months ago (2014-09-08 00:54:24 UTC) #3
jun_fang
On 2014/09/08 00:54:24, Bo Xu wrote: > https://codereview.chromium.org/553613003/diff/1/fpdfsdk/src/fpdfppo.cpp > File fpdfsdk/src/fpdfppo.cpp (right): > > https://codereview.chromium.org/553613003/diff/1/fpdfsdk/src/fpdfppo.cpp#newcode317 ...
6 years, 3 months ago (2014-09-08 17:34:20 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/553613003/diff/20001/fpdfsdk/src/fpdfppo.cpp File fpdfsdk/src/fpdfppo.cpp (right): https://codereview.chromium.org/553613003/diff/20001/fpdfsdk/src/fpdfppo.cpp#newcode316 fpdfsdk/src/fpdfppo.cpp:316: CPDF_Object* pClone = NULL; nit: maybe this reads ...
6 years, 3 months ago (2014-09-08 17:36:20 UTC) #5
jun_fang
On 2014/09/08 17:36:20, Tom Sepez wrote: > lgtm > > https://codereview.chromium.org/553613003/diff/20001/fpdfsdk/src/fpdfppo.cpp > File fpdfsdk/src/fpdfppo.cpp (right): ...
6 years, 3 months ago (2014-09-08 17:51:19 UTC) #6
Tom Sepez
Still LGTM. https://codereview.chromium.org/553613003/diff/60001/fpdfsdk/src/fpdfppo.cpp File fpdfsdk/src/fpdfppo.cpp (right): https://codereview.chromium.org/553613003/diff/60001/fpdfsdk/src/fpdfppo.cpp#newcode322 fpdfsdk/src/fpdfppo.cpp:322: CPDF_Object* pClone = pDirect->Clone(); nit: stray space ...
6 years, 3 months ago (2014-09-08 17:58:34 UTC) #7
jun_fang
6 years, 3 months ago (2014-09-08 18:27:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 4cf3695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698