Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: net/quic/quic_connection.h

Issue 553583007: QUIC cleanup to remove an unused bool argument in SendOrQueuePacket and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index c734387ba696eaf34114255fc1312a60e0c25599..807c7d301560d01b816644dfd0511a0549283afc 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -374,7 +374,7 @@ class NET_EXPORT_PRIVATE QuicConnection
virtual QuicAckFrame* CreateAckFrame() OVERRIDE;
virtual QuicCongestionFeedbackFrame* CreateFeedbackFrame() OVERRIDE;
virtual QuicStopWaitingFrame* CreateStopWaitingFrame() OVERRIDE;
- virtual bool OnSerializedPacket(const SerializedPacket& packet) OVERRIDE;
+ virtual void OnSerializedPacket(const SerializedPacket& packet) OVERRIDE;
// QuicSentPacketManager::NetworkChangeVisitor
virtual void OnCongestionWindowChange(
@@ -526,16 +526,9 @@ class NET_EXPORT_PRIVATE QuicConnection
// can be handled, false otherwise.
virtual bool ProcessValidatedPacket();
- // Send a packet to the peer using encryption |level|. If |sequence_number|
- // is present in the |retransmission_map_|, then contents of this packet will
- // be retransmitted with a new sequence number if it's not acked by the peer.
- // Deletes |packet| if WritePacket call succeeds, or transfers ownership to
- // QueuedPacket, ultimately deleted in WriteQueuedPackets. Updates the
- // entropy map corresponding to |sequence_number| using |entropy_hash|.
- // |transmission_type| and |retransmittable| are supplied to the congestion
- // manager, and when |forced| is true, it bypasses the congestion manager.
- // TODO(wtc): none of the callers check the return value.
- virtual bool SendOrQueuePacket(EncryptionLevel level,
+ // Send a packet to the peer, and takes ownership of the packet if the packet
+ // cannot be written immediately.
+ virtual void SendOrQueuePacket(EncryptionLevel level,
const SerializedPacket& packet,
TransmissionType transmission_type);
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698