Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: net/quic/test_tools/quic_test_utils.cc

Issue 553583007: QUIC cleanup to remove an unused bool argument in SendOrQueuePacket and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/test_tools/quic_test_utils.h" 5 #include "net/quic/test_tools/quic_test_utils.h"
6 6
7 #include "base/sha1.h" 7 #include "base/sha1.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "net/quic/crypto/crypto_framer.h" 10 #include "net/quic/crypto/crypto_framer.h"
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 bool is_server, 295 bool is_server,
296 const QuicVersionVector& supported_versions) 296 const QuicVersionVector& supported_versions)
297 : MockConnection(is_server, supported_versions) { 297 : MockConnection(is_server, supported_versions) {
298 } 298 }
299 299
300 PacketSavingConnection::~PacketSavingConnection() { 300 PacketSavingConnection::~PacketSavingConnection() {
301 STLDeleteElements(&packets_); 301 STLDeleteElements(&packets_);
302 STLDeleteElements(&encrypted_packets_); 302 STLDeleteElements(&encrypted_packets_);
303 } 303 }
304 304
305 bool PacketSavingConnection::SendOrQueuePacket( 305 void PacketSavingConnection::SendOrQueuePacket(
306 EncryptionLevel level, 306 EncryptionLevel level,
307 const SerializedPacket& packet, 307 const SerializedPacket& packet,
308 TransmissionType transmission_type) { 308 TransmissionType transmission_type) {
309 packets_.push_back(packet.packet); 309 packets_.push_back(packet.packet);
310 QuicEncryptedPacket* encrypted = QuicConnectionPeer::GetFramer(this)-> 310 QuicEncryptedPacket* encrypted = QuicConnectionPeer::GetFramer(this)->
311 EncryptPacket(level, packet.sequence_number, *packet.packet); 311 EncryptPacket(level, packet.sequence_number, *packet.packet);
312 encrypted_packets_.push_back(encrypted); 312 encrypted_packets_.push_back(encrypted);
313 return true;
314 } 313 }
315 314
316 MockSession::MockSession(QuicConnection* connection) 315 MockSession::MockSession(QuicConnection* connection)
317 : QuicSession(connection, DefaultQuicConfig()) { 316 : QuicSession(connection, DefaultQuicConfig()) {
318 InitializeSession(); 317 InitializeSession();
319 ON_CALL(*this, WritevData(_, _, _, _, _, _)) 318 ON_CALL(*this, WritevData(_, _, _, _, _, _))
320 .WillByDefault(testing::Return(QuicConsumedData(0, false))); 319 .WillByDefault(testing::Return(QuicConsumedData(0, false)));
321 } 320 }
322 321
323 MockSession::~MockSession() { 322 MockSession::~MockSession() {
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 // different way, so TestWriterFactory::OnPacketSent might never be called. 665 // different way, so TestWriterFactory::OnPacketSent might never be called.
667 factory_->current_writer_ = this; 666 factory_->current_writer_ = this;
668 return QuicPerConnectionPacketWriter::WritePacket(buffer, 667 return QuicPerConnectionPacketWriter::WritePacket(buffer,
669 buf_len, 668 buf_len,
670 self_address, 669 self_address,
671 peer_address); 670 peer_address);
672 } 671 }
673 672
674 } // namespace test 673 } // namespace test
675 } // namespace net 674 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698