dm/DMWriteTask.h - Issue 553583004: Remove expectations / -r from DM entirely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMWriteTask.h

Issue 553583004: Remove expectations / -r from DM entirely. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMWriteTask.h

diff --git a/dm/DMWriteTask.h b/dm/DMWriteTask.h

index fad9262c33193ea5881620b93c43d60be524bbcb..f83289ca2e5860da5067cb0c4b5ca9004157e27d 100644

--- a/dm/DMWriteTask.h

+++ b/dm/DMWriteTask.h

@@ -1,7 +1,6 @@

#ifndef DMWriteTask_DEFINED

#define DMWriteTask_DEFINED

-#include "DMExpectations.h"

#include "DMTask.h"

#include "SkBitmap.h"

#include "SkJSONCPP.h"

@@ -29,16 +28,6 @@ public:

virtual bool shouldSkip() const SK_OVERRIDE;

virtual SkString name() const SK_OVERRIDE;

- // Reads JSON file WriteTask wrote under root and compares the bitmap with checksums inside.

- class Expectations : public DM::Expectations {

- public:

- static Expectations* Create(const char*);

- bool check(const Task& task, SkBitmap bitmap) const SK_OVERRIDE;

- private:

- Expectations() {}

- Json::Value fJson;

- };

static void DumpJson();

private:

« no previous file with comments | « dm/DMUtil.h ('k') | dm/DMWriteTask.cpp » ('j') | no next file with comments »