Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 553583004: Remove expectations / -r from DM entirely. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove expectations / -r from DM entirely. It's getting tricky to coordinate changes to output for bots with -r, and -r is not widely used. The suggested alternative is to run skdiff. BUG=skia: Committed: https://skia.googlesource.com/skia/+/197ceda92966359962c51923a01dd2b0018b080f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -180 lines) Patch
M dm/DM.cpp View 7 chunks +15 lines, -31 lines 0 comments Download
M dm/DMCpuGMTask.h View 3 chunks +0 lines, -3 lines 0 comments Download
M dm/DMCpuGMTask.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
D dm/DMExpectations.h View 1 chunk +0 lines, -19 lines 0 comments Download
D dm/DMExpectationsTask.h View 1 chunk +0 lines, -29 lines 0 comments Download
D dm/DMExpectationsTask.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M dm/DMGpuGMTask.h View 3 chunks +0 lines, -3 lines 0 comments Download
M dm/DMGpuGMTask.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M dm/DMPDFRasterizeTask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMPDFTask.h View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMSKPTask.h View 3 chunks +1 line, -3 lines 0 comments Download
M dm/DMSKPTask.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M dm/DMUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMWriteTask.h View 2 chunks +0 lines, -11 lines 0 comments Download
M dm/DMWriteTask.cpp View 2 chunks +1 line, -42 lines 0 comments Download
M gyp/dm.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years, 3 months ago (2014-09-08 20:35:47 UTC) #2
jcgregorio
On 2014/09/08 20:35:47, mtklein wrote: LGTM
6 years, 3 months ago (2014-09-09 12:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/553583004/20001
6 years, 3 months ago (2014-09-09 14:29:27 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 14:37:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 197ceda92966359962c51923a01dd2b0018b080f

Powered by Google App Engine
This is Rietveld 408576698