chrome/browser/resources/options/website_settings.js - Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/website_settings.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1

Patch Set: fixed comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/confirm_dialog.js ('K') | « chrome/browser/resources/options/supervised_user_list.js ('k') | chrome/browser/resources/sync_setup_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/website_settings.js

diff --git a/chrome/browser/resources/options/website_settings.js b/chrome/browser/resources/options/website_settings.js

index 06a29cd2d260be89af20c7c0451a5ebc5466c716..69c509edf0a3b379356e50b666365c15c155a602 100644

--- a/chrome/browser/resources/options/website_settings.js

+++ b/chrome/browser/resources/options/website_settings.js

@@ -86,12 +86,14 @@ cr.define('options', function() {

* @private

createOriginsList_: function() {

- this.allowedList_ = $('allowed-origin-list');

- options.OriginList.decorate(this.allowedList_);

+ var allowedList = $('allowed-origin-list');

+ options.OriginList.decorate(allowedList);

+ this.allowedList_ = allowedList;

Dan Beam 2014/09/11 05:26:12 did you mean to have an assertInstanceof() here?

Vitaly Pavlenko 2014/09/11 21:12:31 Done.

this.allowedList_.autoExpands = true;

- this.blockedList_ = $('blocked-origin-list');

- options.OriginList.decorate(this.blockedList_);

+ var blockedList = $('blocked-origin-list');

+ options.OriginList.decorate(blockedList);

+ this.blockedList_ = blockedList;

this.blockedList_.autoExpands = true;