Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2546)

Unified Diff: chrome/browser/resources/options/chromeos/bluetooth_device_list.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1
Patch Set: mark narrow type in createItem JSDoc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/bluetooth_device_list.js
diff --git a/chrome/browser/resources/options/chromeos/bluetooth_device_list.js b/chrome/browser/resources/options/chromeos/bluetooth_device_list.js
index a7cadb837d4171531d53f20a39e451cfe72f7271..ce2277990767da5fcba1e8b6aaffd14027d9557b 100644
--- a/chrome/browser/resources/options/chromeos/bluetooth_device_list.js
+++ b/chrome/browser/resources/options/chromeos/bluetooth_device_list.js
@@ -53,10 +53,10 @@ cr.define('options.system.bluetooth', function() {
* connected: boolean,
* connecting: boolean,
* connectable: boolean,
- * pairing: string|undefined,
- * passkey: number|undefined,
- * pincode: string|undefined,
- * entered: number|undefined}}
+ * pairing: (string|undefined),
+ * passkey: (number|undefined),
+ * pincode: (string|undefined),
+ * entered: (number|undefined)}}
Dan Beam 2014/09/11 02:53:08 @typedef this (maybe as BluetoohDevice?) and share
Vitaly Pavlenko 2014/09/11 04:16:25 Done.
*/
data: null,
@@ -141,10 +141,10 @@ cr.define('options.system.bluetooth', function() {
* connected: boolean,
* connecting: boolean,
* connectable: boolean,
- * pairing: string|undefined,
- * passkey: number|undefined,
- * pincode: string|undefined,
- * entered: number|undefined}} device
+ * pairing: (string|undefined),
+ * passkey: (number|undefined),
+ * pincode: (string|undefined),
+ * entered: (number|undefined)}} device
* Description of the bluetooth device.
* @return {boolean} True if the devies was successfully added or updated.
*/
@@ -184,14 +184,14 @@ cr.define('options.system.bluetooth', function() {
/**
* Retrieves the address of the selected device, or null if no device is
* selected.
- * @return {?string} Address of selected device or null.
+ * @return {(string|undefined)} Address of selected device or null.
* @private
*/
getSelectedDevice_: function() {
var selection = this.selectedItem;
if (selection)
return selection.address;
- return null;
+ return undefined;
},
/**
@@ -250,7 +250,7 @@ cr.define('options.system.bluetooth', function() {
return {
height: this.itemHeight_,
marginTop: 0,
- marginBotton: 0,
Dan Beam 2014/09/11 02:53:08 is this used?
Vitaly Pavlenko 2014/09/11 04:16:25 Rarely: https://code.google.com/p/chromium/codese
+ marginBottom: 0,
width: this.itemWidth_,
marginLeft: 0,
marginRight: 0

Powered by Google App Engine
This is Rietveld 408576698