chrome/browser/resources/options/autofill_edit_address_overlay.js - Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/autofill_edit_address_overlay.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1

Patch Set: fixed crash on assertInstanceof Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/user_images_grid.js ('k') | chrome/browser/resources/options/autofill_edit_creditcard_overlay.js » ('j') | chrome/browser/resources/options/autofill_edit_creditcard_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/autofill_edit_address_overlay.js

diff --git a/chrome/browser/resources/options/autofill_edit_address_overlay.js b/chrome/browser/resources/options/autofill_edit_address_overlay.js

index f81bb94a4efa64eaab9d192659f72785104d255e..b5aec2d1561806fb319b62af252e921744b258dd 100644

--- a/chrome/browser/resources/options/autofill_edit_address_overlay.js

+++ b/chrome/browser/resources/options/autofill_edit_address_overlay.js

@@ -234,17 +234,17 @@ cr.define('options', function() {

var inputFields = this.getInputFields_();

var address = [

this.guid_,

- inputFields.fullName || [],

- inputFields.companyName || '',

- inputFields.addrLines || '',

- inputFields.dependentLocality || '',

- inputFields.city || '',

- inputFields.state || '',

- inputFields.postalCode || '',

- inputFields.sortingCode || '',

- inputFields.country || '',

- inputFields.phone || [],

- inputFields.email || [],

+ inputFields['fullName'] || [],

+ inputFields['companyName'] || '',

+ inputFields['addrLines'] || '',

+ inputFields['dependentLocality'] || '',

+ inputFields['city'] || '',

+ inputFields['state'] || '',

+ inputFields['postalCode'] || '',

+ inputFields['sortingCode'] || '',

+ inputFields['country'] || '',

+ inputFields['phone'] || [],

+ inputFields['email'] || [],

this.languageCode_,

];

chrome.send('setAddress', address);

@@ -436,7 +436,8 @@ cr.define('options', function() {

AutofillEditAddressOverlay.setValidatedPhoneNumbers = function(numbers) {

var instance = AutofillEditAddressOverlay.getInstance();

var phoneList = instance.pageDiv.querySelector('[field=phone]');

- instance.setMultiValueList_(phoneList, numbers);

+ instance.setMultiValueList_(assertInstanceof(phoneList, cr.ui.List),

+ numbers);

phoneList.didReceiveValidationResult();

};