Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4293)

Unified Diff: chrome/browser/resources/options/chromeos/network_list.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/network_list.js
diff --git a/chrome/browser/resources/options/chromeos/network_list.js b/chrome/browser/resources/options/chromeos/network_list.js
index 392a94989ba7e78b4244095322d46c0f569153d4..32e694d029dd6fcecb6af1ef162f6b2012a78e29 100644
--- a/chrome/browser/resources/options/chromeos/network_list.js
+++ b/chrome/browser/resources/options/chromeos/network_list.js
@@ -620,7 +620,8 @@ cr.define('options.network', function() {
/**
* Extracts a mapping of network names to menu element and position.
* @param {!Element} menu The menu to process.
- * @return {Object.<string, Element>} Network mapping.
+ * @return {Object.<string, {index: number, button: Element}>}
+ * Network mapping.
* @private
*/
extractNetworkConnectButtons_: function(menu) {
@@ -696,7 +697,7 @@ cr.define('options.network', function() {
/**
* Adds a command to a menu for modifying network settings.
* @param {!Element} menu Parent menu.
- * @param {!Object} data Description of the network.
+ * @param {Object} data Description of the network.
* @param {!string} label Display name for the menu item.
* @param {?(string|!Function)} command Callback function or name
* of the command for |networkCommand|.
@@ -937,8 +938,12 @@ cr.define('options.network', function() {
/**
* Chrome callback for updating network controls.
- * @param {Object} data Description of available network devices and their
- * corresponding state.
+ * @param {{wiredList: Array, wirelessList: Array, vpnList: Array,
+ * rememberedList: Array, wifiAvailable: boolean, wifiEnabled: boolean,
+ * wimaxAvailable: boolean, wimaxEnabled: boolean,
+ * cellularAvailable: boolean, cellularEnabled: boolean,
+ * cellularSupportsScan: boolean}} data Description of available network
+ * devices and their corresponding state.
*/
NetworkList.refreshNetworkData = function(data) {
var networkList = $('network-list');
@@ -1120,7 +1125,7 @@ cr.define('options.network', function() {
/**
* Fetches the active connection.
* @param {Array.<Object>} networkList List of networks.
- * @return {boolean} True if connected or connecting to a network.
+ * @return {Object}
* @private
*/
function getConnection_(networkList) {
@@ -1149,7 +1154,6 @@ cr.define('options.network', function() {
/**
* Whether the Network list is disabled. Only used for display purpose.
- * @type {boolean}
*/
cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
« no previous file with comments | « chrome/browser/resources/options/chromeos/internet_detail.js ('k') | chrome/browser/resources/options/chromeos/onc_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698