Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/website_settings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /////////////////////////////////////////////////////////////////////////////
@@ skipping 68 matching lines @@
       this.updatePage_(hash);
 
       $('resourceType').value = hash;
     },
 
     /**
      * Creates, decorates and initializes the origin list.
      * @private
      */
     createOriginsList_: function() {
-      this.allowedList_ = $('allowed-origin-list');
-      options.OriginList.decorate(this.allowedList_);
+      var allowedList = $('allowed-origin-list');
+      options.OriginList.decorate(allowedList);
+      this.allowedList_ = allowedList;

[Dan Beam, 2014/09/11 05:26:12]

did you mean to have an assertInstanceof() here?

[Vitaly Pavlenko, 2014/09/11 21:12:31]

Done.

       this.allowedList_.autoExpands = true;
 
-      this.blockedList_ = $('blocked-origin-list');
-      options.OriginList.decorate(this.blockedList_);
+      var blockedList = $('blocked-origin-list');
+      options.OriginList.decorate(blockedList);
+      this.blockedList_ = blockedList;
       this.blockedList_.autoExpands = true;
     },
 
     /**
      * Populate an origin list with all of the origins with a given permission
      * or that are using a given resource.
      * @param {OriginList} originList A list to populate.
      * @param {!Object} originDict A dictionary of origins to their usage, which
            will be used to sort the origins.
      * @private
@@ skipping 87 matching lines @@
 
   WebsiteSettingsManager.showEditPage = function(url) {
     WebsiteSettingsEditor.getInstance().populatePage(url);
   };
 
   // Export
   return {
     WebsiteSettingsManager: WebsiteSettingsManager
   };
 });