Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/autofill_edit_creditcard_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
 
   /**
    * AutofillEditCreditCardOverlay class
@@ skipping 92 matching lines @@
     /**
      * Sets the default values of the options in the 'Expiration date' select
      * controls.
      * @private
      */
     setDefaultSelectOptions_: function() {
       // Set the 'Expiration month' default options.
       var expirationMonth = $('expiration-month');
       expirationMonth.options.length = 0;
       for (var i = 1; i <= 12; ++i) {
-        var text;
-        if (i < 10)
-          text = '0' + i;
-        else
-          text = i;
+        var text = (i < 10 ? '0' : '') + i;
 
         var option = document.createElement('option');
-        option.text = text;
-        option.value = text;
+        option.text = option.value = text;
         expirationMonth.add(option, null);
       }
 
       // Set the 'Expiration year' default options.
       var expirationYear = $('expiration-year');
       expirationYear.options.length = 0;
 
       var date = new Date();
       var year = parseInt(date.getFullYear(), 10);
       for (var i = 0; i < 10; ++i) {
         var text = year + i;
         var option = document.createElement('option');
-        option.text = text;
+        option.text = String(text);
         option.value = text;
         expirationYear.add(option, null);
       }
     },
 
     /**
      * Clears the value of each input field.
      * @private
      */
     clearInputFields_: function() {
       $('name-on-card').value = '';
       $('credit-card-number').value = '';
       $('expiration-month').selectedIndex = 0;
       $('expiration-year').selectedIndex = 0;
 
       // Reset the enabled status of the 'Ok' button.
       this.inputFieldChanged_();
     },
 
     /**
      * Sets the value of each input field according to |creditCard|
+     * @param {CreditCardData} creditCard
      * @private
      */
     setInputFields_: function(creditCard) {
       $('name-on-card').value = creditCard.nameOnCard;
       $('credit-card-number').value = creditCard.creditCardNumber;
 
       // The options for the year select control may be out-dated at this point,
       // e.g. the user opened the options page before midnight on New Year's Eve
       // and then loaded a credit card profile to edit in the new year, so
       // reload the select options just to be safe.
       this.setDefaultSelectOptions_();
 
       var idx = parseInt(creditCard.expirationMonth, 10);
       $('expiration-month').selectedIndex = idx - 1;
 
-      expYear = creditCard.expirationYear;
+      var expYear = creditCard.expirationYear;
       var date = new Date();
       var year = parseInt(date.getFullYear(), 10);
       for (var i = 0; i < 10; ++i) {
         var text = year + i;
         if (expYear == String(text))
           $('expiration-year').selectedIndex = i;
       }
     },
 
     /**
      * Called to prepare the overlay when a new card is being added.
      * @private
      */
     prepForNewCard_: function() {
       // Focus the first element.
       this.pageDiv.querySelector('input').focus();
     },
 
     /**
      * Loads the credit card data from |creditCard|, sets the input fields based
      * on this data and stores the GUID of the credit card.
+     * @param {CreditCardData} creditCard
      * @private
      */
     loadCreditCard_: function(creditCard) {
       this.setInputFields_(creditCard);
       this.inputFieldChanged_();
       this.guid_ = creditCard.guid;
     },
   };
 
   AutofillEditCreditCardOverlay.prepForNewCard = function() {
     AutofillEditCreditCardOverlay.getInstance().prepForNewCard_();
   };
 
   AutofillEditCreditCardOverlay.loadCreditCard = function(creditCard) {
     AutofillEditCreditCardOverlay.getInstance().loadCreditCard_(creditCard);
   };
 
   AutofillEditCreditCardOverlay.setTitle = function(title) {
     $('autofill-credit-card-title').textContent = title;
   };
 
   // Export
   return {
     AutofillEditCreditCardOverlay: AutofillEditCreditCardOverlay
   };
 });