Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('options');
 
+/** @typedef {{appsEnforced: boolean,
+ *             appsRegistered: boolean,
+ *             appsSynced: boolean,
+ *             autofillEnforced: boolean,
+ *             autofillRegistered: boolean,
+ *             autofillSynced: boolean,
+ *             bookmarksEnforced: boolean,
+ *             bookmarksRegistered: boolean,
+ *             bookmarksSynced: boolean,
+ *             encryptAllData: boolean,
+ *             enterGooglePassphraseBody: (string|undefined),
+ *             enterPassphraseBody: (string|undefined),
+ *             extensionsEnforced: boolean,
+ *             extensionsRegistered: boolean,
+ *             extensionsSynced: boolean,
+ *             fullEncryptionBody: string,
+ *             isSupervised: boolean,
+ *             passphraseFailed: boolean,
+ *             passwordsEnforced: boolean,
+ *             passwordsRegistered: boolean,
+ *             passwordsSynced: boolean,
+ *             preferencesEnforced: boolean,
+ *             preferencesRegistered: boolean,
+ *             preferencesSynced: boolean,
+ *             showPassphrase: boolean,
+ *             showSyncEverythingPage: boolean,
+ *             syncAllDataTypes: boolean,
+ *             syncNothing: boolean,
+ *             tabsEnforced: boolean,
+ *             tabsRegistered: boolean,
+ *             tabsSynced: boolean,
+ *             themesEnforced: boolean,
+ *             themesRegistered: boolean,
+ *             themesSynced: boolean,
+ *             typedUrlsEnforced: boolean,
+ *             typedUrlsRegistered: boolean,
+ *             typedUrlsSynced: boolean,
+ *             usePassphrase: boolean}}
+ */
+var SyncArgs;

[Dan Beam, 2014/09/11 02:53:09]

nit: SyncConfig

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done.

+
 /**
  * The user's selection in the synced data type drop-down menu, as an index.
  * @enum {number}
  * @const
  */
 options.DataTypeSelection = {
   SYNC_EVERYTHING: 0,
   CHOOSE_WHAT_TO_SYNC: 1,
   SYNC_NOTHING: 2
 };
@@ skipping 144 matching lines @@
       }
     },
 
     /**
      * Enables / grays out the sync data type checkboxes in the advanced
      * settings dialog.
      * @param {boolean} enabled True for enabled, false for grayed out.
      * @private
      */
     setDataTypeCheckboxesEnabled_: function(enabled) {
-      for (dataType in dataTypeBoxesDisabled_) {
+      for (var dataType in dataTypeBoxesDisabled_) {
         $(dataType).disabled = !enabled || dataTypeBoxesDisabled_[dataType];
       }
     },
 
     /**
      * Sets the state of the sync data type checkboxes based on whether "Sync
      * everything", "Choose what to sync", or "Sync nothing" are selected in the
      * drop-down menu of the advanced settings dialog.
      * @param {options.DataTypeSelection} selectedIndex Index of user's
      *     selection.
@@ skipping 123 matching lines @@
             options.DataTypeSelection.SYNC_EVERYTHING);
         return false;
       };
     },
 
     /**
      * Shows or hides the sync data type checkboxes in the advanced sync
      * settings dialog. Also initializes |dataTypeBoxesChecked_| and
      * |dataTypeBoxedDisabled_| with their values, and makes their onclick
      * handlers update |dataTypeBoxesChecked_|.
-     * @param {Object} args The configuration data used to show/hide UI.
+     * @param {SyncArgs} args The configuration data used to show/hide UI.
      * @private
      */
     setChooseDataTypesCheckboxes_: function(args) {
       var datatypeSelect = $('sync-select-datatypes');
       datatypeSelect.selectedIndex = args.syncAllDataTypes ?
           options.DataTypeSelection.SYNC_EVERYTHING :
           options.DataTypeSelection.CHOOSE_WHAT_TO_SYNC;
 
       $('bookmarks-checkbox').checked = args.bookmarksSynced;
       dataTypeBoxesChecked_['bookmarks-checkbox'] = args.bookmarksSynced;
@@ skipping 73 matching lines @@
      * |dataTypeBoxesChecked_|. Used as an onclick handler for each data type
      * checkbox.
      * @private
      */
     handleDataTypeClick_: function() {
       dataTypeBoxesChecked_[this.id] = this.checked;
       chrome.send('coreOptionsUserMetricsAction',
                   ['Options_SyncToggleDataType']);
     },
 
+    /**
+     * @param {SyncArgs} args
+     */
     setEncryptionRadios_: function(args) {
       if (!args.encryptAllData && !args.usePassphrase) {
         $('basic-encryption-option').checked = true;
       } else {
         $('full-encryption-option').checked = true;
         $('full-encryption-option').disabled = true;
         $('basic-encryption-option').disabled = true;
       }
     },
 
+    /**
+     * @param {SyncArgs} args
+     */
     setCheckboxesAndErrors_: function(args) {
       this.setChooseDataTypesCheckboxes_(args);
       this.setEncryptionRadios_(args);
     },
 
+    /**
+     * @param {SyncArgs} args
+     */
     showConfigure_: function(args) {
       var datatypeSelect = $('sync-select-datatypes');
       var self = this;
 
       // Cache the sync config args so they can be reused when we transition
       // between the drop-down menu items in the advanced settings dialog.
       if (args)
         this.syncConfigureArgs_ = args;
 
       // Required in order to determine whether to give focus to the OK button
@@ skipping 115 matching lines @@
       // Hide the "use default settings" link.
       $('use-default-link').hidden = true;
       $('use-default-link').disabled = true;
       $('use-default-link').onclick = null;
     },
 
     /**
      * Reveals the UI for entering a custom passphrase during initial setup.
      * This happens if the user has previously enabled a custom passphrase on a
      * different machine.
-     * @param {Array} args The args that contain the passphrase UI
+     * @param {SyncArgs} args The args that contain the passphrase UI
      *     configuration.
      * @private
      */
     showPassphraseContainer_: function(args) {
       // Once we require a passphrase, we prevent the user from returning to
       // the Sync Everything pane.
       $('use-default-link').hidden = true;
       $('use-default-link').disabled = true;
       $('use-default-link').onclick = null;
       $('sync-custom-passphrase-container').hidden = true;
@@ skipping 18 matching lines @@
       // previously but failed).
       $('incorrect-passphrase').hidden =
           !(args.usePassphrase && args.passphraseFailed);
 
       $('sync-passphrase-warning').hidden = false;
     },
 
     /**
      * Displays the advanced sync setting dialog, and pre-selects either the
      * "Sync everything" or the "Choose what to sync" drop-down menu item.
+     * @param {SyncArgs} args
      * @param {options.DataTypeSelection} index Index of item to pre-select.
      * @private
      */
     showCustomizePage_: function(args, index) {
       // Determine whether to bring the OK button field into focus.
       var wasCustomizePageHidden = !this.customizePageVisible_;
       this.customizePageVisible_ = true;
       this.confirmPageVisible_ = false;
 
       $('confirm-sync-preferences').hidden = true;
@@ skipping 27 matching lines @@
         $('use-default-link').onclick = function() {
           SyncSetupOverlay.showSyncEverythingPage();
           return false;
         };
       }
     },
 
     /**
      * Shows the appropriate sync setup page.
      * @param {string} page A page of the sync setup to show.
-     * @param {Object} args Data from the C++ to forward on to the right
+     * @param {SyncArgs} args Data from the C++ to forward on to the right
      *     section.
      */
     showSyncSetupPage_: function(page, args) {
       // If the user clicks the OK button, dismiss the dialog immediately, and
       // do not go through the process of hiding elements of the overlay.
       // See crbug.com/308873.
       if (page == 'done') {
         this.closeOverlay_();
         return;
       }
@@ skipping 152 matching lines @@
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });