Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/supervised_user_list.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.supervisedUserOptions', function() {
   /** @const */ var List = cr.ui.List;
   /** @const */ var ListItem = cr.ui.ListItem;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
   /**
@@ skipping 78 matching lines @@
   /**
    * Create a new supervised users list.
    * @constructor
    * @extends {cr.ui.List}
    */
   var SupervisedUserList = cr.ui.define('list');
 
   SupervisedUserList.prototype = {
     __proto__: List.prototype,
 
-    /** @override */
+    /**
+     * @override
+     * @param {Object} entry

[Dan Beam, 2014/09/11 02:53:09]

^ why does this need a @param if it's @override?

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Hm, at least it works. Btw, there's a lot of overloaded createItem's, and every
waits for its own type. So I either write this type inside @param or do a cast
in the function body. Which way is better?

[Dan Beam, 2014/09/11 05:26:12]

this is fine

[Vitaly Pavlenko, 2014/09/11 21:12:31]

Acknowledged.

+     */
     createItem: function(entry) {
       return new SupervisedUserListItem(entry);
     },
 
     /** @override */
     decorate: function() {
       List.prototype.decorate.call(this);
       this.selectionModel = new ListSingleSelectionModel();
       this.autoExpands = true;
     },
   };
 
   return {
     SupervisedUserListItem: SupervisedUserListItem,
     SupervisedUserList: SupervisedUserList,
   };
 });