Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/controlled_setting.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Preferences = options.Preferences;
 
   /**
    * A controlled setting indicator that can be placed on a setting as an
    * indicator that the value is controlled by some external entity such as
@@ skipping 49 matching lines @@
       PageManager.hideBubble();
       if (event.value.controlledBy) {
         if (!this.value || String(event.value.value) == this.value) {
           this.controlledBy = event.value.controlledBy;
           if (event.value.extension) {
             this.extensionId = event.value.extension.id;
             this.extensionIcon = event.value.extension.icon;
             this.extensionName = event.value.extension.name;
           }
         } else {
-          this.controlledBy = null;
+          this.controlledBy = '';
         }
       } else if (event.value.recommendedValue != undefined) {
         this.controlledBy =
             !this.value || String(event.value.recommendedValue) == this.value ?
-            'hasRecommendation' : null;
+            'hasRecommendation' : '';

[Dan Beam, 2014/09/11 02:53:09]

nit: indent + 4\s more

[Vitaly Pavlenko, 2014/09/11 04:16:25]

This way?

       } else {
-        this.controlledBy = null;
+        this.controlledBy = '';
       }
     },
 
     /**
      * Open or close a bubble with further information about the pref.
      * @override
      */
     toggleBubble: function() {
       if (this.showingBubble) {
         PageManager.hideBubble();
@@ skipping 138 matching lines @@
    * - unset:               The value is controlled by the user alone.
    */
   cr.defineProperty(ControlledSettingIndicator, 'controlledBy',
                     cr.PropertyKind.ATTR);
 
   // Export.
   return {
     ControlledSettingIndicator: ControlledSettingIndicator
   };
 });