Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/chromeos/display_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/**
+ * @typedef {{
+ *   availableColorProfiles: Array.<{profileId: number, name: string}>,
+ *   colorProfile: number,
+ *   height: number,
+ *   id: string,
+ *   isInternal: boolean,
+ *   isPrimary: boolean,
+ *   resolutions: Array.<{width: number, height: number, originalWidth: number,
+ *       originalHeight: number, deviceScaleFactor: number, scale: number,
+ *       refreshRate: number, isBest: boolean, selected: boolean}>,
+ *   name: string,
+ *   orientation: number,
+ *   width: number,
+ *   x: number,
+ *   y: number
+ * }}
+ */
+var DisplayInfo;
+
+cr.exportPath('options');

[Dan Beam, 2014/09/11 02:53:09]

why not options.{DisplayInfo,SecondaryDisplayLayout} with this exportPath()
higher up?

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done for SecondaryDisplayLayout.

I don't include @typedef's into namespaces so far. Should I?

[Dan Beam, 2014/09/11 05:26:12]

if the @typedef's never used outside of the namespace, probably better to, yeah

[Vitaly Pavlenko, 2014/09/11 21:12:30]

Done.

+
+/**
+ * Enumeration of secondary display layout.  The value has to be same as the
+ * values in ash/display/display_controller.cc.
+ * @enum {number}
+ */
+var SecondaryDisplayLayout = {
+  TOP: 0,
+  RIGHT: 1,
+  BOTTOM: 2,
+  LEFT: 3
+};
+
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
   // The scale ratio of the display rectangle to its original size.
   /** @const */ var VISUAL_SCALE = 1 / 10;
 
   // The number of pixels to share the edges between displays.
   /** @const */ var MIN_OFFSET_OVERLAP = 5;
 
   /**
-   * Enumeration of secondary display layout.  The value has to be same as the
-   * values in ash/display/display_controller.cc.
-   * @enum {number}
-   */
-  var SecondaryDisplayLayout = {
-    TOP: 0,
-    RIGHT: 1,
-    BOTTOM: 2,
-    LEFT: 3
-  };
-
-  /**
    * Calculates the bounds of |element| relative to the page.
    * @param {HTMLElement} element The element to be known.
    * @return {Object} The object for the bounds, with x, y, width, and height.
    */
   function getBoundsInPage(element) {
     var bounds = {
       x: element.offsetLeft,
       y: element.offsetTop,
       width: element.offsetWidth,
       height: element.offsetHeight
@@ skipping 57 matching lines @@
 
     /**
      * The current secondary display layout.
      * @private
      */
     layout_: SecondaryDisplayLayout.RIGHT,
 
     /**
      * The array of current output displays.  It also contains the display
      * rectangles currently rendered on screen.
+     * @type {Array.<DisplayInfo>}
      * @private
      */
     displays_: [],
 
     /**
      * The index for the currently focused display in the options UI.  null if
      * no one has focus.
      * @private
      */
     focusedIndex_: null,
@@ skipping 702 matching lines @@
         // |displaysView_|.  Otherwise its offsetHeight is yet 0.
         displayNameContainer.style.marginTop =
             (div.offsetHeight - displayNameContainer.offsetHeight) / 2 + 'px';
         display.originalPosition = {x: div.offsetLeft, y: div.offsetTop};
       }
     },
 
     /**
      * Called when the display arrangement has changed.
      * @param {boolean} mirroring Whether current mode is mirroring or not.
-     * @param {Array} displays The list of the display information.
+     * @param {Array.<DisplayInfo>} displays The list of the display
+     *     information.
      * @param {SecondaryDisplayLayout} layout The layout strategy.
      * @param {number} offset The offset of the secondary display.
      * @private
      */
     onDisplayChanged_: function(mirroring, displays, layout, offset) {
       if (!this.visible)
         return;
 
       var hasExternal = false;
       for (var i = 0; i < displays.length; i++) {
@@ skipping 35 matching lines @@
       mirroring, displays, layout, offset) {
     DisplayOptions.getInstance().onDisplayChanged_(
         mirroring, displays, layout, offset);
   };
 
   // Export
   return {
     DisplayOptions: DisplayOptions
   };
 });