Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/chromeos/bluetooth_device_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.system.bluetooth', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
@@ skipping 29 matching lines @@
     // devices.
     el.deletable = device.paired && !device.connecting;
     return el;
   }
 
   BluetoothListItem.prototype = {
     __proto__: DeletableItem.prototype,
 
     /**
      * Description of the Bluetooth device.
      * @type {{name: string,

[Dan Beam, 2014/09/11 02:53:08]

nit: doesn't this need a nullable ?

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done.

      *         address: string,
      *         paired: boolean,
      *         connected: boolean,
      *         connecting: boolean,
      *         connectable: boolean,
-     *         pairing: string|undefined,
-     *         passkey: number|undefined,
-     *         pincode: string|undefined,
-     *         entered: number|undefined}}
+     *         pairing: (string|undefined),
+     *         passkey: (number|undefined),
+     *         pincode: (string|undefined),
+     *         entered: (number|undefined)}}

[Dan Beam, 2014/09/11 02:53:08]

@typedef this (maybe as BluetoohDevice?) and share with appendDevice

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done.

      */
     data: null,
 
     /** @override */
     decorate: function() {
       DeletableItem.prototype.decorate.call(this);
       var label = this.ownerDocument.createElement('div');
       label.className = 'bluetooth-device-label';
       this.classList.add('bluetooth-device');
       // There are four kinds of devices we want to distinguish:
@@ skipping 64 matching lines @@
     /**
      * Adds a bluetooth device to the list of available devices. A check is
      * made to see if the device is already in the list, in which case the
      * existing device is updated.
      * @param {{name: string,
      *          address: string,
      *          paired: boolean,
      *          connected: boolean,
      *          connecting: boolean,
      *          connectable: boolean,
-     *          pairing: string|undefined,
-     *          passkey: number|undefined,
-     *          pincode: string|undefined,
-     *          entered: number|undefined}} device
+     *          pairing: (string|undefined),
+     *          passkey: (number|undefined),
+     *          pincode: (string|undefined),
+     *          entered: (number|undefined)}} device
      *     Description of the bluetooth device.
      * @return {boolean} True if the devies was successfully added or updated.
      */
     appendDevice: function(device) {
       var selectedDevice = this.getSelectedDevice_();
       var index = this.find(device.address);
       if (index == undefined) {
         this.dataModel.push(device);
         this.redraw();
       } else {
@@ skipping 19 matching lines @@
           this.getSelectedDevice_();
       this.invalidate();
       this.redraw();
       if (selectedDevice)
         this.setSelectedDevice_(selectedDevice);
     },
 
     /**
      * Retrieves the address of the selected device, or null if no device is
      * selected.
-     * @return {?string} Address of selected device or null.
+     * @return {(string|undefined)} Address of selected device or null.
      * @private
      */
     getSelectedDevice_: function() {
       var selection = this.selectedItem;
       if (selection)
         return selection.address;
-      return null;
+      return undefined;
     },
 
     /**
      * Selects the device with the matching address.
      * @param {string} address The unique address of the device.
      * @private
      */
     setSelectedDevice_: function(address) {
       var index = this.find(address);
       if (index != undefined)
@@ skipping 38 matching lines @@
      * case.
      * @return {{height: number, marginTop: number, marginBottom: number,
      *     width: number, marginLeft: number, marginRight: number}}
      *     The height and width of the item, taking margins into account,
      *     and the margins themselves.
      */
     measureItem: function() {
       return {
         height: this.itemHeight_,
         marginTop: 0,
-        marginBotton: 0,

[Dan Beam, 2014/09/11 02:53:08]

is this used?

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Rarely:

https://code.google.com/p/chromium/codesearch#search/&q=measureItem%5C(%5C)&s...

Particularly, I see no point where marginBottom/marginRight is used.

+        marginBottom: 0,
         width: this.itemWidth_,
         marginLeft: 0,
         marginRight: 0
       };
     },
 
     /**
      * Override the default implementation to return a predetermined size,
      * which in turns allows proper layout of items even if the list is hidden.
      * @return {{height: number, width: number}} Dimensions of a single item in
@@ skipping 74 matching lines @@
 
   cr.defineProperty(BluetoothListItem, 'notconnectable',
       cr.PropertyKind.BOOL_ATTR);
 
   return {
     BluetoothListItem: BluetoothListItem,
     BluetoothDeviceList: BluetoothDeviceList,
     Constants: Constants
   };
 });