Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/autofill_options_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.autofillOptions', function() {
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var InlineEditableItem = options.InlineEditableItem;
   /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
 
   /**
    * @return {!HTMLButtonElement}
    */
   function AutofillEditProfileButton(guid, edit) {
-    var editButtonEl = document.createElement('button');
+    var editButtonEl = /** @type {HTMLButtonElement} */(
+        document.createElement('button'));
     editButtonEl.className = 'list-inline-button custom-appearance';
     editButtonEl.textContent =
         loadTimeData.getString('autofillEditProfileButton');
     editButtonEl.onclick = function(e) { edit(guid); };
 
     editButtonEl.onmousedown = function(e) {
       // Don't select the row when clicking the button.
       e.stopPropagation();
       // Don't focus on the button when clicking it.
       e.preventDefault();
@@ skipping 79 matching lines @@
       // The 'Edit' button.
       var editButtonEl = AutofillEditProfileButton(
         this.guid,
         AutofillOptions.loadCreditCardEditor);
       this.contentElement.appendChild(editButtonEl);
     },
   };
 
   /**
    * Creates a new value list item.
-   * @param {AutofillValuesList} list The parent list of this item.
+   * @param {options.autofillOptions.AutofillValuesList} list The parent list of
+   *     this item.
    * @param {string} entry A string value.
    * @constructor
    * @extends {options.InlineEditableItem}
    */
   function ValuesListItem(list, entry) {
     var el = cr.doc.createElement('div');
     el.list = list;
     el.value = entry ? entry : '';
     el.__proto__ = ValuesListItem.prototype;
     el.decorate();
 
     return el;
   }
 
   ValuesListItem.prototype = {
     __proto__: InlineEditableItem.prototype,
 
     /** @override */
     decorate: function() {
       InlineEditableItem.prototype.decorate.call(this);
 
       // Note: This must be set prior to calling |createEditableTextCell|.
       this.isPlaceholder = !this.value;
 
       // The stored value.
-      var cell = this.createEditableTextCell(this.value);
+      var cell = this.createEditableTextCell(String(this.value));
       this.contentElement.appendChild(cell);
       this.input = cell.querySelector('input');
 
       if (this.isPlaceholder) {
         this.input.placeholder = this.list.getAttribute('placeholder');
         this.deletable = false;
       }
 
       this.addEventListener('commitedit', this.onEditCommitted_);
     },
 
     /**
-     * @return {string} This item's value.
+     * @return {Array} This item's value.
      * @protected
      */
     value_: function() {
       return this.input.value;
     },
 
     /**
-     * @param {Object} value The value to test.
+     * @param {*} value The value to test.
      * @return {boolean} True if the given value is non-empty.
      * @protected
      */
     valueIsNonEmpty_: function(value) {
       return !!value;
     },
 
     /**
      * @return {boolean} True if value1 is logically equal to value2.
      */
@@ skipping 46 matching lines @@
       }
     },
   };
 
   /**
    * Creates a new name value list item.
    * @param {options.autofillOptions.AutofillNameValuesList} list The parent
    *     list of this item.
    * @param {Array.<string>} entry An array of [first, middle, last] names.
    * @constructor
-   * @extends {options.ValuesListItem}
+   * @extends {options.autofillOptions.ValuesListItem}
    */
   function NameListItem(list, entry) {
     var el = cr.doc.createElement('div');
     el.list = list;
     el.first = entry ? entry[0] : '';
     el.middle = entry ? entry[1] : '';
     el.last = entry ? entry[2] : '';
     el.__proto__ = NameListItem.prototype;
     el.decorate();
 
@@ skipping 91 matching lines @@
      * @private
      */
     onBlur_: function() {
       this.selectionModel.unselectAll();
     },
   };
 
   /**
    * Create a new address list.
    * @constructor
-   * @extends {options.AutofillProfileList}
+   * @extends {options.autofillOptions.AutofillProfileList}
    */
   var AutofillAddressList = cr.ui.define('list');
 
   AutofillAddressList.prototype = {
     __proto__: AutofillProfileList.prototype,
 
     decorate: function() {
       AutofillProfileList.prototype.decorate.call(this);
     },
 
     /** @override */
     activateItemAtIndex: function(index) {
       AutofillOptions.loadAddressEditor(this.dataModel.item(index)[0]);
     },
 
     /** @override */
     createItem: function(entry) {
-      return new AddressListItem(entry);
+      return new AddressListItem(/** @type {Array} */(entry));
     },
 
     /** @override */
     deleteItemAtIndex: function(index) {
       AutofillOptions.removeData(this.dataModel.item(index)[0]);
     },
   };
 
   /**
    * Create a new credit card list.
    * @constructor
    * @extends {options.DeletableItemList}
    */
   var AutofillCreditCardList = cr.ui.define('list');
 
   AutofillCreditCardList.prototype = {
     __proto__: AutofillProfileList.prototype,
 
     decorate: function() {
       AutofillProfileList.prototype.decorate.call(this);
     },
 
     /** @override */
     activateItemAtIndex: function(index) {
       AutofillOptions.loadCreditCardEditor(this.dataModel.item(index)[0]);
     },
 
     /** @override */
     createItem: function(entry) {
-      return new CreditCardListItem(entry);
+      return new CreditCardListItem(/** @type {Array} */(entry));
     },
 
     /** @override */
     deleteItemAtIndex: function(index) {
       AutofillOptions.removeData(this.dataModel.item(index)[0]);
     },
   };
 
   /**
    * Create a new value list.
    * @constructor
    * @extends {options.InlineEditableItemList}
    */
   var AutofillValuesList = cr.ui.define('list');
 
   AutofillValuesList.prototype = {
     __proto__: InlineEditableItemList.prototype,
 
     /** @override */
     createItem: function(entry) {
-      return new ValuesListItem(this, entry);
+      return new ValuesListItem(this, /** @type {string} */(entry));
     },
 
     /** @override */
     deleteItemAtIndex: function(index) {
       this.dataModel.splice(index, 1);
     },
 
     /** @override */
     shouldFocusPlaceholder: function() {
       return false;
@@ skipping 35 matching lines @@
      * @param {string} value The value of the item to insert.
      */
     validateAndSave: function(index, remove, value) {
       this.dataModel.splice(index, remove, value);
     },
   };
 
   /**
    * Create a new value list for phone number validation.
    * @constructor
-   * @extends {options.AutofillValuesList}
+   * @extends {options.autofillOptions.AutofillValuesList}
    */
   var AutofillNameValuesList = cr.ui.define('list');
 
   AutofillNameValuesList.prototype = {
     __proto__: AutofillValuesList.prototype,
 
     /** @override */
     createItem: function(entry) {
-      return new NameListItem(this, entry);
+      return new NameListItem(this, /** @type {Array.<string>} */(entry));
     },
   };
 
   /**
    * Create a new value list for phone number validation.
    * @constructor
-   * @extends {options.AutofillValuesList}
+   * @extends {options.autofillOptions.AutofillValuesList}
    */
   var AutofillPhoneValuesList = cr.ui.define('list');
 
   AutofillPhoneValuesList.prototype = {
     __proto__: AutofillValuesList.prototype,
 
     /** @override */
     validateAndSave: function(index, remove, value) {
       var numbers = this.dataModel.slice(0, this.dataModel.length - 1);
       numbers.splice(index, remove, value);
@@ skipping 42 matching lines @@
     doneValidating: function() {
       if (this.validationRequests_ <= 0)
         return Promise.resolve();
       return new Promise(function(resolve) {
         this.validationPromiseResolvers_.push(resolve);
       }.bind(this));
     }
   };
 
   return {
+    AutofillProfileList: AutofillProfileList,
     AddressListItem: AddressListItem,
     CreditCardListItem: CreditCardListItem,
     ValuesListItem: ValuesListItem,
     NameListItem: NameListItem,
     AutofillAddressList: AutofillAddressList,
     AutofillCreditCardList: AutofillCreditCardList,
     AutofillValuesList: AutofillValuesList,
     AutofillNameValuesList: AutofillNameValuesList,
     AutofillPhoneValuesList: AutofillPhoneValuesList,
   };
 });