Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 5535006: Add unittests for net::TestRootCerts and regenerate test certificates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address wtc feedback Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/valgrind/valgrind_test.py
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py
index 0280b1dca83e2427c52b3434e7fc9d466ab6b209..75eaa5e2d9247f89c581b9e9e171586fc292d321 100755
--- a/tools/valgrind/valgrind_test.py
+++ b/tools/valgrind/valgrind_test.py
@@ -327,15 +327,6 @@ class ValgrindTool(BaseTool):
We need to run some sanity checks, set up a Wine prefix, and make sure
wineserver is running by starting a dummy win32 program.
"""
- if not os.path.exists('/usr/share/ca-certificates/root_ca_cert.crt'):
- logging.warning('WARNING: SSL certificate missing! SSL tests will fail.')
- logging.warning('You need to run:')
- logging.warning('sudo cp src/net/data/ssl/certificates/root_ca_cert.crt '
- '/usr/share/ca-certificates/')
- logging.warning('sudo vi /etc/ca-certificates.conf')
- logging.warning(' (and add the line root_ca_cert.crt)')
- logging.warning('sudo update-ca-certificates')
wtc 2010/12/08 19:58:22 IMPORTANT: I don't know what this code is for. Is
Ryan Sleevi 2010/12/09 05:49:55 Wine's way of implementing trusted root certs. Rat
-
# Shutdown the Wine server in case the last run got interrupted.
common.RunSubprocess([os.environ.get('WINESERVER'), '-k'])

Powered by Google App Engine
This is Rietveld 408576698