net/cert/test_root_certs_android.cc - Issue 5535006: Add unittests for net::TestRootCerts and regenerate test certificates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/test_root_certs_android.cc

Issue 5535006: Add unittests for net::TestRootCerts and regenerate test certificates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bump certs again, add script to auto-rengerate Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/test_root_certs_android.cc

diff --git a/net/cert/test_root_certs_android.cc b/net/cert/test_root_certs_android.cc

index a7b80c472074a0bdff17e1771a789ffcf5a7d337..73588270e9557b1d0d795ea984a04c49b8a7d3a1 100644

--- a/net/cert/test_root_certs_android.cc

+++ b/net/cert/test_root_certs_android.cc

@@ -18,6 +18,7 @@ bool TestRootCerts::Add(X509Certificate* certificate) {

return false;

android::AddTestRootCertificate(

reinterpret_cast<const uint8*>(cert_bytes.data()), cert_bytes.size());

+ empty_ = false;

wtc 2013/06/18 22:51:45 This is a bug fix, right?

Ryan Sleevi 2013/06/18 23:57:59 Yes, picked up by the TestRootCerts test.

return true;

}