Chromium Code Reviews
Help | Chromium Project | Sign in
(754)

Issue 5535006: Add unittests for net::TestRootCerts and regenerate test certificates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Ryan Sleevi
Modified:
10 months ago
Reviewers:
Dirk Pranke, wtc, jam, M-A Ruel, zel
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr., brettw-cc_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, joth (inactive)
Visibility:
Public.

Description

Regenerate the root certificate and end-entity certificates used for various tests in net_unittests, now that Windows can temporarily trust certificates for the duration of tests.

In addition, add unittests for net::TestRootCerts, which depend on the certs being tested not being trusted by the system beforehand.

BUG=8470, 5552
TEST=TestRootCertsTest.*
TBR=zelidrag

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207443

Patch Set 1 #

Patch Set 2 : Address wtc feedback #

Total comments: 10

Patch Set 3 : More feedback #

Patch Set 4 : Update the layout_tests cert, just in case #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased yet again #

Patch Set 7 : More fixes #

Patch Set 8 : Bump HPKP test data #

Patch Set 9 : Mangle pin so its a backup pin #

Patch Set 10 : Rebased #

Patch Set 11 : Android fix #

Patch Set 12 : rebased yet again #

Patch Set 13 : Bump certs again, add script to auto-rengerate #

Total comments: 8

Patch Set 14 : Review feedback #

Patch Set 15 : line length #

Patch Set 16 : Fix another hardcoded string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+790 lines, -216 lines) Lint Patch
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments ? errors Download
M chrome/common/net/x509_certificate_model_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/interactive_ui_tests.isolate View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/android/javatests/src/org/chromium/net/X509UtilTest.java View 1 2 3 4 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/cert/cert_verify_proc_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/cert/nss_cert_database_unittest.cc View 1 2 3 4 10 chunks +10 lines, -10 lines 0 comments ? errors Download
M net/cert/test_root_certs_android.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments ? errors Download
A net/cert/test_root_certs_unittest.cc View 1 2 3 4 1 chunk +142 lines, -0 lines 0 comments 2 errors Download
M net/data/ssl/certificates/README View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -7 lines 0 comments ? errors Download
M net/data/ssl/certificates/expired_cert.pem View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +108 lines, -39 lines 0 comments ? errors Download
M net/data/ssl/certificates/ok_cert.pem View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +108 lines, -39 lines 0 comments ? errors Download
M net/data/ssl/certificates/root_ca_cert.crt View 1 1 chunk +0 lines, -35 lines 0 comments ? errors Download
A net/data/ssl/certificates/root_ca_cert.pem View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +102 lines, -0 lines 0 comments ? errors Download
M net/data/ssl/scripts/ca.cnf View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments ? errors Download
A net/data/ssl/scripts/generate-test-certs.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +81 lines, -0 lines 0 comments ? errors Download
M net/data/ssl/scripts/generate-weak-test-chains.sh View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments ? errors Download
M net/test/spawned_test_server/base_test_server.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments ? errors Download
M ppapi/tests/test_tcp_socket_private_trusted.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments ? errors Download
M tools/python/google/httpd_config/httpd2.pem View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +108 lines, -39 lines 0 comments ? errors Download
M tools/python/google/httpd_config/root_ca_cert.crt View 1 2 3 1 chunk +0 lines, -35 lines 0 comments ? errors Download
A tools/python/google/httpd_config/root_ca_cert.pem View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +102 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 31
Ryan Sleevi
wtc: here's the regenerated certificates, split into a new CL per your comments on http://codereview.chromium.org/4646001/ ...
3 years, 4 months ago #1
wtc
LGTM. Please do not check this in until the following issues have been addressed. 1. ...
3 years, 4 months ago #2
Ryan Sleevi
+cc joth, as an FYI since I'm adding a TODO(joth) +review maruel & nsylvain, as ...
3 years, 4 months ago #3
M-A Ruel
On 2010/12/09 05:49:55, Ryan Sleevi wrote: > +review maruel & nsylvain, as I'm going to ...
3 years, 4 months ago #4
Nicolas Sylvain
On Thu, Dec 9, 2010 at 6:08 AM, <maruel@chromium.org> wrote: > On 2010/12/09 05:49:55, Ryan ...
3 years, 4 months ago #5
Ryan Sleevi
nsylvain: Sorry I wasn't clear in the original +review : This is actually a second ...
3 years, 4 months ago #6
Nicolas Sylvain
On Thu, Dec 9, 2010 at 8:44 AM, <rsleevi@chromium.org> wrote: > nsylvain: > > Sorry ...
3 years, 4 months ago #7
M-A Ruel
lgtm
3 years, 4 months ago #8
Ryan Sleevi
ping dpranke: Is the WebKit file used in production? Or is it an upstream contribution ...
3 years, 4 months ago #9
Dirk Pranke
Whoops, sorry for missing the comments earlier. I'm 99.8% certain the upstream code is not ...
3 years, 4 months ago #10
Dirk Pranke
cleanup time ... do we care about this patch at this point?
10 months, 4 weeks ago #11
Ryan Sleevi
On 2013/05/24 19:53:55, Dirk Pranke wrote: > cleanup time ... do we care about this ...
10 months, 4 weeks ago #12
Ryan Sleevi
So it seems every HTTPS test in Chrome Frame is disabled at the moment. Given ...
10 months ago #13
Dirk Pranke
seems reasonable to me. Do we need to update LayoutTests/http/conf/webkit-httpd.pem as well?
10 months ago #14
Ryan Sleevi
On 2013/06/18 00:05:30, Dirk Pranke wrote: > seems reasonable to me. Do we need to ...
10 months ago #15
Dirk Pranke
On 2013/06/18 00:07:27, Ryan Sleevi wrote: > On 2013/06/18 00:05:30, Dirk Pranke wrote: > > ...
10 months ago #16
Ryan Sleevi
On 2013/06/18 00:12:31, Dirk Pranke wrote: > On 2013/06/18 00:07:27, Ryan Sleevi wrote: > > ...
10 months ago #17
wtc
Patch set 13 LGTM. I'm sorry that I didn't know I should review this CL ...
10 months ago #18
Ryan Sleevi
https://codereview.chromium.org/5535006/diff/113041/net/cert/test_root_certs_android.cc File net/cert/test_root_certs_android.cc (right): https://codereview.chromium.org/5535006/diff/113041/net/cert/test_root_certs_android.cc#newcode21 net/cert/test_root_certs_android.cc:21: empty_ = false; On 2013/06/18 22:51:45, wtc wrote: > ...
10 months ago #19
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/5535006/127041
10 months ago #20
I haz the power (commit-bot)
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10106
10 months ago #21
Ryan Sleevi
zel, jam: TBR for one line file name change
10 months ago #22
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/5535006/127041
10 months ago #23
I haz the power (commit-bot)
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=10119
10 months ago #24
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/5535006/132042
10 months ago #25
I haz the power (commit-bot)
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=139910
10 months ago #26
jam
chrome lgtm
10 months ago #27
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/5535006/132042
10 months ago #28
I haz the power (commit-bot)
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=52381
10 months ago #29
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/5535006/114064
10 months ago #30
I haz the power (commit-bot)
10 months ago #31
Message was sent while issue was closed.
Change committed as 207443
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6