Revert of [oilpan]: optimize the way we allocate persistent handles in wrappers.

Revert of [oilpan]: optimize the way we allocate persistent handles in wrappers. (patchset #6 id:100001 of https://codereview.chromium.org/525353002/)

Reason for revert:
Reverting due to browser test failures.

Original issue's description:
> [oilpan]: optimize the way we allocate persistent handles in wrappers.
> 
> The oilpan JS wrappers all have a persistent which is used to keep the wrapped object around while there is a javascript reference to it. Allocation of these wrapper persistents showed up in some of benchmarks. This change creates a new optimized WrapperPersistent which is allocated in blocks. This gives a speedup ranging between a few percent to 20% in some of the more wrapper intensive tests.
> 
> R=ager@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181298

TBR=ager@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,zerny@chromium.org,erik.corry@gmail.com,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411240
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181553

[wibling-chromium, 2014-09-08 09:38:23]

Created Revert of [oilpan]: optimize the way we allocate persistent handles in
wrappers.

[commit-bot: I haz the power, 2014-09-08 09:38:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wibling@chromium.org/553483004/1

[commit-bot: I haz the power, 2014-09-08 09:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 09:39:06]

Failed to apply patch for Source/bindings/core/v8/V8DOMWrapper.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/core/v8/V8DOMWrapper.h
  Hunk #3 FAILED at 142.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/bindings/core/v8/V8DOMWrapper.h.rej

Patch:       Source/bindings/core/v8/V8DOMWrapper.h
Index: Source/bindings/core/v8/V8DOMWrapper.h
diff --git a/Source/bindings/core/v8/V8DOMWrapper.h
b/Source/bindings/core/v8/V8DOMWrapper.h
index
60c22fef58c84100d342434987c2584def765129..53ae3649ccf58cca59db68a7ce703fa689c79dd8
100644
--- a/Source/bindings/core/v8/V8DOMWrapper.h
+++ b/Source/bindings/core/v8/V8DOMWrapper.h
@@ -60,7 +60,7 @@
     static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(Node*,
const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*);
     static void setNativeInfo(v8::Handle<v8::Object>, const WrapperTypeInfo*,
ScriptWrappableBase* internalPointer);
     static void setNativeInfoForHiddenWrapper(v8::Handle<v8::Object>, const
WrapperTypeInfo*, ScriptWrappableBase* internalPointer);
-    static void setNativeInfoWithPersistentHandle(v8::Handle<v8::Object>, const
WrapperTypeInfo*, ScriptWrappableBase* internalPointer, WrapperPersistentNode*);
+    static void setNativeInfoWithPersistentHandle(v8::Handle<v8::Object>, const
WrapperTypeInfo*, ScriptWrappableBase* internalPointer, PersistentNode*);
     static void clearNativeInfo(v8::Handle<v8::Object>, const
WrapperTypeInfo*);
 
     static bool isDOMWrapper(v8::Handle<v8::Value>);
@@ -104,7 +104,7 @@
     wrapper->SetAlignedPointerInInternalField(v8DOMWrapperTypeIndex,
const_cast<WrapperTypeInfo*>(wrapperTypeInfo));
 }
 
-inline void
V8DOMWrapper::setNativeInfoWithPersistentHandle(v8::Handle<v8::Object> wrapper,
const WrapperTypeInfo* wrapperTypeInfo, ScriptWrappableBase* internalPointer,
WrapperPersistentNode* handle)
+inline void
V8DOMWrapper::setNativeInfoWithPersistentHandle(v8::Handle<v8::Object> wrapper,
const WrapperTypeInfo* wrapperTypeInfo, ScriptWrappableBase* internalPointer,
PersistentNode* handle)
 {
     ASSERT(wrapper->InternalFieldCount() >= 3);
     ASSERT(internalPointer);
@@ -142,7 +142,7 @@
 template<typename V8T, typename T>
 inline v8::Handle<v8::Object> V8DOMWrapper::associateObjectWithWrapper(T*
object, const WrapperTypeInfo* wrapperTypeInfo, v8::Handle<v8::Object> wrapper,
v8::Isolate* isolate)
 {
-    setNativeInfoWithPersistentHandle(wrapper, wrapperTypeInfo,
V8T::toInternalPointer(object), new WrapperPersistent<T>(object));
+    setNativeInfoWithPersistentHandle(wrapper, wrapperTypeInfo,
V8T::toInternalPointer(object), new Persistent<T>(object));
     ASSERT(isDOMWrapper(wrapper));
     DOMDataStore::setWrapper<V8T>(object, wrapper, isolate, wrapperTypeInfo);
     return wrapper;

[Mads Ager (chromium), 2014-09-08 09:39:07]

LGTM

[haraken, 2014-09-08 09:39:08]

LGTM

[Fabrice (no longer in Chrome), 2014-09-08 09:40:25]

LGTM
Looks like it doesn't revert cleanly but it shouldn't be too hard to fix.
Thanks for doing this!

[wibling-chromium, 2014-09-08 10:34:07]

On 2014/09/08 09:40:25, Fabrice de Gans wrote:
> LGTM
> Looks like it doesn't revert cleanly but it shouldn't be too hard to fix.
> Thanks for doing this!

Bummer. Looking into it.

[wibling-chromium, 2014-09-08 11:14:42]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-09-08 11:15:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wibling@chromium.org/553483004/300001

[commit-bot: I haz the power, 2014-09-08 11:16:38]

Committed patchset #2 (id:300001) as 181553