PDF Viewer - Show context menu for links on right click

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 1224 matching lines @@
 
 void PDFiumEngine::PrintEnd() {
   FORM_DoDocumentAAction(form_, FPDFDOC_AACTION_DP);
 }
 
 PDFiumPage::Area PDFiumEngine::GetCharIndex(
     const pp::MouseInputEvent& event, int* page_index,
     int* char_index, PDFiumPage::LinkTarget* target) {
   // First figure out which page this is in.
   pp::Point mouse_point = event.GetPosition();
-  pp::Point point(
-      static_cast<int>((mouse_point.x() + position_.x()) / current_zoom_),
-      static_cast<int>((mouse_point.y() + position_.y()) / current_zoom_));
-  return GetCharIndex(point, page_index, char_index, target);
+  return GetCharIndex(mouse_point, page_index, char_index, target);
 }
 
 PDFiumPage::Area PDFiumEngine::GetCharIndex(

[raymes, 2014/09/08 01:25:38]

It looks like this function expects |point| to be in page coordinates. I think
it's only called from 3 places:
1) From GetCharIndex which provides |point| in page coordinates.
2) Recursively, which also provides |point| in page coordinates.
3) From GetLinkAtPosition which seems not to provide |point| in page
coordinates.

I think the right fix is to change GetLinkAtPosition to provide |point| in page
coordinates. Currently the transformation to the point is being applied multiple
times if this function recurses which I think is incorrect.

[Nikhil, 2014/09/08 05:59:12]

Done.

     const pp::Point& point,
     int* page_index,
     int* char_index,
     PDFiumPage::LinkTarget* target) {
+  pp::Point test_point(
+      static_cast<int>((point.x() + position_.x()) / current_zoom_),
+      static_cast<int>((point.y() + position_.y()) / current_zoom_));
+
   int page = -1;
   for (size_t i = 0; i < visible_pages_.size(); ++i) {
-    if (pages_[visible_pages_[i]]->rect().Contains(point)) {
+    if (pages_[visible_pages_[i]]->rect().Contains(test_point)) {
       page = visible_pages_[i];
       break;
     }
   }
   if (page == -1)
     return PDFiumPage::NONSELECTABLE_AREA;
 
   // If the page hasn't finished rendering, calling into the page sometimes
   // leads to hangs.
   for (size_t i = 0; i < progressive_paints_.size(); ++i) {
     if (progressive_paints_[i].page_index == page)
       return PDFiumPage::NONSELECTABLE_AREA;
   }
 
   *page_index = page;
-  return pages_[page]->GetCharIndex(point, current_rotation_, char_index,
-                                    target);
+  return pages_[page]->GetCharIndex(
+      test_point, current_rotation_, char_index, target);
 }
 
 bool PDFiumEngine::OnMouseDown(const pp::MouseInputEvent& event) {
   if (event.GetButton() != PP_INPUTEVENT_MOUSEBUTTON_LEFT)
     return false;
 
   SelectionChangeInvalidator selection_invalidator(this);
   selection_.clear();
 
   int page_index = -1;
@@ skipping 2136 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf