Get rid of FileManagerPrivateAPI class

Get rid of FileManagerPrivateAPI class

The whole purpose of FileManagerPrivateAPI class was to hold an
EventRouter instance. It's simpler to just make EventRouter a
KeyedService and get rid of FileManagerPrivateAPI.

Note that BrowserContextKeyedAPI could not be used for EventRouter as
EventRouter needs a Profile rather than a BrowserContext.

In the next patch, EventRouter will be renamed to something like
FileManagerService.

BUG=412643
TEST=Files.app works as before

Committed: https://crrev.com/cc16383345552189dd0d33a931ed4b719354eae9
Cr-Commit-Position: refs/heads/master@{#294351}

[satorux1, 2014-09-10 07:08:44]

Patchset #1 (id:1) has been deleted

[satorux1, 2014-09-10 07:11:21]

satorux@chromium.org changed reviewers:
+ mtomasz@chromium.org

[satorux1, 2014-09-10 07:11:22]

mtomasz: everything
benwells: chrome/browser/extensions/browser_context_keyed_service_factories.cc
(two-line change)

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/browser_context_keyed_service_factories.cc
(right):

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/browser_context_keyed_service_factories.cc:160:
file_manager::EventRouterFactory::GetInstance();
As mentioned in the patch description, the class will be renamed to something
like FileManagerService in a separate patch.

[mtomasz, 2014-09-10 07:29:30]

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/event_router.h (right):

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/event_router.h:66: void
ObserveEvents();
ObserveEvents() is now not called anymore. Maybe we should just call it from the
constructor?

[satorux1, 2014-09-11 04:12:51]

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/event_router.h (right):

https://codereview.chromium.org/553393002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/event_router.h:66: void
ObserveEvents();
On 2014/09/10 07:29:30, mtomasz wrote:
> ObserveEvents() is now not called anymore. Maybe we should just call it from
the
> constructor?

Good catch! Called it from the constructor and made it private.

[mtomasz, 2014-09-11 05:02:28]

lgtm

[benwells, 2014-09-11 05:10:51]

benwells@chromium.org changed reviewers:
+ benwells@chromium.org

[benwells, 2014-09-11 05:10:52]

lgtm

[satorux1, 2014-09-11 05:12:27]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2014-09-11 05:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/553393002/60001

[commit-bot: I haz the power, 2014-09-11 07:58:09]

Committed patchset #3 (id:60001) as 49c9fb6e07226bcc975e9de597536d49c20b06cb

[commit-bot: I haz the power, 2014-09-11 08:19:20]

Patchset 3 (id:??) landed as
https://crrev.com/cc16383345552189dd0d33a931ed4b719354eae9
Cr-Commit-Position: refs/heads/master@{#294351}