Makes InfoBarService not close infobars on a reload from browser instant

chrome/browser/infobars/infobar_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INFOBARS_INFOBAR_SERVICE_H_
 #define CHROME_BROWSER_INFOBARS_INFOBAR_SERVICE_H_
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 19 matching lines @@
   static infobars::InfoBarDelegate::NavigationDetails
       NavigationDetailsFromLoadCommittedDetails(
           const content::LoadCommittedDetails& details);
 
   // This function must only be called on infobars that are owned by an
   // InfoBarService instance (or not owned at all, in which case this returns
   // NULL).
   static content::WebContents* WebContentsFromInfoBar(
       infobars::InfoBar* infobar);
 
+  // Makes it so the next reload is ignored. That is, if the next commit is a
+  // reload than it is treated as if nothing happened and no infobars are

[Peter Kasting, 2014/09/18 17:48:04]

Nit: than -> then

[sky, 2014/09/18 19:22:27]

Done.

+  // attempted to be closed.

[Peter Kasting, 2014/09/18 17:48:04]

Nit: Remove "attempted to be"

Consider adding a motivation clause as to why this functionality is useful.

[sky, 2014/09/18 19:22:27]

Done.

+  void set_ignore_next_reload() { ignore_next_reload_ = true; }
+
  private:
   friend class content::WebContentsUserData<InfoBarService>;
 
   explicit InfoBarService(content::WebContents* web_contents);
   virtual ~InfoBarService();
 
   // InfoBarManager:
   virtual int GetActiveEntryID() OVERRIDE;
   // TODO(droger): Remove these functions once infobar notifications are
   // removed. See http://crbug.com/354380
   virtual void NotifyInfoBarAdded(infobars::InfoBar* infobar) OVERRIDE;
   virtual void NotifyInfoBarRemoved(infobars::InfoBar* infobar,
                                     bool animate) OVERRIDE;
 
   // content::WebContentsObserver:
   virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
+  virtual void DidStartNavigationToPendingEntry(
+      const GURL& url,
+      content::NavigationController::ReloadType reload_type) OVERRIDE;
   virtual void NavigationEntryCommitted(
       const content::LoadCommittedDetails& load_details) OVERRIDE;
   virtual void WebContentsDestroyed() OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // Message handlers.
   void OnDidBlockDisplayingInsecureContent();
   void OnDidBlockRunningInsecureContent();
 
+  // See description in set_ignore_next_reload().
+  bool ignore_next_reload_;
 
   DISALLOW_COPY_AND_ASSIGN(InfoBarService);
 };
 
 #endif  // CHROME_BROWSER_INFOBARS_INFOBAR_SERVICE_H_