Bypass ServiceWorkers for synchronous resource loads.

Bypass ServiceWorkers for synchronous resource loads to avoid deadlocks when the worker and page are running in the same process.

[1] this cl
[2] layout test https://codereview.chromium.org/573293005/

BUG=413103
Committed: https://crrev.com/f7028cffa4dfd50ed54497ce30b91a7f0b72e808
Cr-Commit-Position: refs/heads/master@{#297315}

[michaeln, 2014-09-17 21:37:33]

michaeln@chromium.org changed reviewers:
+ horo@chromium.org

[michaeln, 2014-09-17 21:37:34]

ptal, i'll add a layout test too

[horo, 2014-09-17 21:42:15]

On 2014/09/17 21:37:34, michaeln wrote:
> ptal, i'll add a layout test too

looks-good!
Thank you for taking this issue.

[michaeln, 2014-09-17 23:09:00]

the layout tests are in https://codereview.chromium.org/573293005/

[horo, 2014-09-18 00:48:05]

lgtm

[michaeln1, 2014-09-19 18:34:00]

The CQ bit was checked by michaeln@google.com

[commit-bot: I haz the power, 2014-09-19 18:35:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/553333005/1

[commit-bot: I haz the power, 2014-09-19 18:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 18:46:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[michaeln, 2014-09-19 21:48:02]

michaeln@chromium.org changed reviewers:
+ mmenke@chromium.org
- michaeln@google.com

[michaeln, 2014-09-19 21:48:38]

@mmenke for OWNERS please

[mmenke, 2014-09-23 14:35:10]

On 2014/09/19 21:48:38, michaeln wrote:
> @mmenke for OWNERS please

Given how bad behavior is on regression (Potentially locking up everything in
the renderer process until it's killed), should we have a browser test for this?

[jsbell, 2014-09-26 19:13:29]

On 2014/09/23 14:35:10, mmenke wrote:
> On 2014/09/19 21:48:38, michaeln wrote:
> > @mmenke for OWNERS please
> 
> Given how bad behavior is on regression (Potentially locking up everything in
> the renderer process until it's killed), should we have a browser test for
this?

@mmenke - do you see any particular advantage of a browser test over the layout
test for this?

[mmenke, 2014-09-26 19:15:49]

On 2014/09/26 19:13:29, jsbell wrote:
> On 2014/09/23 14:35:10, mmenke wrote:
> > On 2014/09/19 21:48:38, michaeln wrote:
> > > @mmenke for OWNERS please
> > 
> > Given how bad behavior is on regression (Potentially locking up everything
in
> > the renderer process until it's killed), should we have a browser test for
> this?
> 
> @mmenke - do you see any particular advantage of a browser test over the
layout
> test for this?

I'm fine with a layout test.  I'm completely unfamiliar with the layout test
infrastructure, so someone else will need to review that.

[michaeln, 2014-09-29 19:10:27]

On 2014/09/26 19:15:49, mmenke wrote:
> On 2014/09/26 19:13:29, jsbell wrote:
> > On 2014/09/23 14:35:10, mmenke wrote:
> > > On 2014/09/19 21:48:38, michaeln wrote:
> > > > @mmenke for OWNERS please
> > > 
> > > Given how bad behavior is on regression (Potentially locking up everything
> in
> > > the renderer process until it's killed), should we have a browser test for
> > this?
> > 
> > @mmenke - do you see any particular advantage of a browser test over the
> layout
> > test for this?
> 
> I'm fine with a layout test.  I'm completely unfamiliar with the layout test
> infrastructure, so someone else will need to review that.

The layout test is here, https://codereview.chromium.org/573293005/

[mmenke, 2014-09-29 19:15:56]

LGTM!

https://codereview.chromium.org/553333005/diff/20001/content/browser/loader/r...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/553333005/diff/20001/content/browser/loader/r...
content/browser/loader/resource_dispatcher_host_impl.cc:1148:
request_data.skip_service_worker || is_sync_load,
nit:  Think it's worth a short comment about this.  Something along the lines of
"Don't use service worker for synchronous loads, to prevent hanging on a blocked
renderer"

[michaeln, 2014-09-29 19:34:00]

https://codereview.chromium.org/553333005/diff/20001/content/browser/loader/r...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/553333005/diff/20001/content/browser/loader/r...
content/browser/loader/resource_dispatcher_host_impl.cc:1148:
request_data.skip_service_worker || is_sync_load,
On 2014/09/29 19:15:56, mmenke wrote:
> nit:  Think it's worth a short comment about this.  Something along the lines
of
> "Don't use service worker for synchronous loads, to prevent hanging on a
blocked
> renderer"

Done.

[michaeln, 2014-09-29 21:07:49]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-09-29 21:09:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/553333005/40001

[commit-bot: I haz the power, 2014-09-29 22:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 22:52:38]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaeln, 2014-09-29 23:00:52]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-09-29 23:02:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/553333005/40001

[commit-bot: I haz the power, 2014-09-30 00:08:35]

Committed patchset #3 (id:40001) as 213126cc5b61fb52e2501c95fb5b81976db9f95e

[commit-bot: I haz the power, 2014-09-30 00:09:22]

Patchset 3 (id:??) landed as
https://crrev.com/f7028cffa4dfd50ed54497ce30b91a7f0b72e808
Cr-Commit-Position: refs/heads/master@{#297315}