gyp build of skfiddle apps, take 2

gyp build of skfiddle apps, take 2

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9a0267fa9aa1dab078ab67b40b647de5be80696f

[humper, 2014-09-17 14:07:45]

humper@google.com changed reviewers:
+ jcgregorio@google.com

[humper, 2014-09-17 14:34:28]

ptal, round 2

[jcgregorio, 2014-09-17 15:00:07]

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
File experimental/webtry/gyp_for_webtry (right):

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:7: skia_src =
os.path.abspath(os.environ.get('SKIA_SRC', os.path.join( script_dir, "..", "..")
))
No space after join(

Nor between  ) ))

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:14: args = sys.argv[2:]
Check for correct # of args and exit if not correct.

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:22: webtry_cache_dir =
os.path.abspath(os.environ.get('WEBTRY_CACHE', os.path.join( script_dir, "..",
"..", "..", "cache" ) ))
Getting a little long, maybe break out os.path.join( script_dir, "..", "..",
"..", "cache" ) 
as WEBTRY_CACHE_DEFAULT?

Same for the next line.

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
experimental/webtry/webtry.go:349: 
no blank line here.

[humper, 2014-09-17 15:08:24]

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
File experimental/webtry/gyp_for_webtry (right):

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:7: skia_src =
os.path.abspath(os.environ.get('SKIA_SRC', os.path.join( script_dir, "..", "..")
))
On 2014/09/17 15:00:07, jcgregorio wrote:
> No space after join(
> 
> Nor between  ) ))

Done.

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:14: args = sys.argv[2:]
On 2014/09/17 15:00:07, jcgregorio wrote:
> Check for correct # of args and exit if not correct.

Done.

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
experimental/webtry/gyp_for_webtry:22: webtry_cache_dir =
os.path.abspath(os.environ.get('WEBTRY_CACHE', os.path.join( script_dir, "..",
"..", "..", "cache" ) ))
On 2014/09/17 15:00:07, jcgregorio wrote:
> Getting a little long, maybe break out os.path.join( script_dir, "..", "..",
> "..", "cache" ) 
> as WEBTRY_CACHE_DEFAULT?
> 
> Same for the next line.

Done.

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
experimental/webtry/webtry.go:349: 
On 2014/09/17 15:00:07, jcgregorio wrote:
> no blank line here.

Done.

[jcgregorio, 2014-09-17 15:18:20]

On 2014/09/17 15:08:24, humper wrote:
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
> File experimental/webtry/gyp_for_webtry (right):
> 
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
> experimental/webtry/gyp_for_webtry:7: skia_src =
> os.path.abspath(os.environ.get('SKIA_SRC', os.path.join( script_dir, "..",
"..")
> ))
> On 2014/09/17 15:00:07, jcgregorio wrote:
> > No space after join(
> > 
> > Nor between  ) ))
> 
> Done.
> 
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
> experimental/webtry/gyp_for_webtry:14: args = sys.argv[2:]
> On 2014/09/17 15:00:07, jcgregorio wrote:
> > Check for correct # of args and exit if not correct.
> 
> Done.
> 
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/gyp_...
> experimental/webtry/gyp_for_webtry:22: webtry_cache_dir =
> os.path.abspath(os.environ.get('WEBTRY_CACHE', os.path.join( script_dir, "..",
> "..", "..", "cache" ) ))
> On 2014/09/17 15:00:07, jcgregorio wrote:
> > Getting a little long, maybe break out os.path.join( script_dir, "..", "..",
> > "..", "cache" ) 
> > as WEBTRY_CACHE_DEFAULT?
> > 
> > Same for the next line.
> 
> Done.
> 
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
> File experimental/webtry/webtry.go (right):
> 
>
https://codereview.chromium.org/553333004/diff/20001/experimental/webtry/webt...
> experimental/webtry/webtry.go:349: 
> On 2014/09/17 15:00:07, jcgregorio wrote:
> > no blank line here.
> 
> Done.

LGTM

[humper, 2014-09-17 15:34:03]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-09-17 15:34:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/553333004/40001

[commit-bot: I haz the power, 2014-09-17 15:42:50]

Committed patchset #3 (id:40001) as 9a0267fa9aa1dab078ab67b40b647de5be80696f