Chromium Code Reviews| Index: base/process/memory_win.cc |
| diff --git a/base/process/memory_win.cc b/base/process/memory_win.cc |
| index c53a1be539555f41ed004f194558ad9e3f7a1a99..65b002fb4b776486dea4b348015f1ef78f9d42a6 100644 |
| --- a/base/process/memory_win.cc |
| +++ b/base/process/memory_win.cc |
| @@ -82,4 +82,15 @@ HMODULE GetModuleFromAddress(void* address) { |
| return instance; |
| } |
| +// TODO(b.kelemen): implement it with the required semantics. On Linux this is |
| +// implemented with a weak symbol that is overridden by tcmalloc. This is |
| +// neccessary because base cannot have a direct dependency on tcmalloc. Since |
| +// weak symbols are not supported no Windows this will involve some build time |
| +// magic, much like what is done for libcrt in order to override the allocation |
| +// functions. |
| +bool UncheckedMalloc(size_t size, void** result) { |
| + *result = malloc(size); |
| + return !!*result; |
|
jar (doing other things)
2014/02/26 03:59:52
nit: Clearer might be:
return NULL != *result;
..
|
| +} |
| + |
| } // namespace base |