Make possible to check memory allocations inside chromium

base/process/memory_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include "base/process/memory.h"
 
 #include <limits>
 
@@ skipping 131 matching lines @@
       "was not malloc\\(\\)-ed");
 #else
   ASSERT_DEATH(free(buf), "being freed.*\\n?\\.*"
       "\\*\\*\\* set a breakpoint in malloc_error_break to debug.*\\n?.*"
       "Terminating process due to a potential for future heap corruption");
 #endif  // ARCH_CPU_64_BITS || defined(ADDRESS_SANITIZER)
 }
 
 #endif  // defined(OS_MACOSX)
 
-// Android doesn't implement set_new_handler, so we can't use the
-// OutOfMemoryTest cases.
-// OpenBSD does not support these tests either.
-// AddressSanitizer and ThreadSanitizer define the malloc()/free()/etc.
-// functions so that they don't crash if the program is out of memory, so the
-// OOM tests aren't supposed to work.
-// TODO(vandebo) make this work on Windows too.
-#if !defined(OS_ANDROID) && !defined(OS_OPENBSD) && \
-    !defined(OS_WIN) && \
-    !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER)
-
 #if defined(USE_TCMALLOC)
 extern "C" {
 int tc_set_new_mode(int mode);
 }
 #endif  // defined(USE_TCMALLOC)
 
 class OutOfMemoryDeathTest : public testing::Test {
  public:
   OutOfMemoryDeathTest()
       : value_(NULL),
@@ skipping 20 matching lines @@
     // tests shouldn't be started in a multithread environment, this call
     // should be done inside of the ASSERT_DEATH.
     base::EnableTerminationOnOutOfMemory();
   }
 
   void* value_;
   size_t test_size_;
   ssize_t signed_test_size_;
 };
 
+// Android doesn't implement set_new_handler, so we can't use the
+// OutOfMemoryTest cases.
+// OpenBSD does not support these tests either.
+// AddressSanitizer and ThreadSanitizer define the malloc()/free()/etc.
+// functions so that they don't crash if the program is out of memory, so the
+// OOM tests aren't supposed to work.
+// TODO(vandebo) make this work on Windows too.
+#if !defined(OS_ANDROID) && !defined(OS_OPENBSD) && \
+    !defined(OS_WIN) && \
+    !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER)
+
 TEST_F(OutOfMemoryDeathTest, New) {
   ASSERT_DEATH({
       SetUpInDeathAssert();
       value_ = operator new(test_size_);
     }, "");
 }
 
 TEST_F(OutOfMemoryDeathTest, NewArray) {
   ASSERT_DEATH({
       SetUpInDeathAssert();
@@ skipping 157 matching lines @@
       SetUpInDeathAssert();
       while ((value_ = base::AllocatePsychoticallyBigObjCObject())) {}
     }, "");
 }
 
 #endif  // !ARCH_CPU_64_BITS
 #endif  // OS_MACOSX
 
 #endif  // !defined(OS_ANDROID) && !defined(OS_OPENBSD) &&
         // !defined(OS_WIN) && !defined(ADDRESS_SANITIZER)
+
+// TODO(b.kelemen): make UncheckedMalloc and UncheckedCalloc work
+// well on Windows.
+#if defined(USE_TCMALLOC) || defined(LIBC_GLIBC)
+
+TEST_F(OutOfMemoryDeathTest, UncheckedMalloc) {
+  SetUpInDeathAssert();

[Scott Hess - ex-Googler, 2014/03/13 22:30:33]

This shouldn't be a death test, right?

[kbalazs, 2014/03/13 23:07:00]

No I just tried to reuse the class because I need to do the same initialization.
I will improve.

[Scott Hess - ex-Googler, 2014/03/13 23:18:45]

Yeah, I think "death test" has meaning that you don't want to invoke.

I'm not sure how purist it's worth being on this.  You could use TEST(X, Y), but
X can't be the same as the X from a TEST_F().  Clearly value_ can just be
converted to a local, and I bet that this case doesn't need the other setup. 
But then you need a way to get access to the test_size_.

[kbalazs, 2014/03/18 20:03:54]

I factored the common code into a base class.

+  EXPECT_TRUE(base::UncheckedMalloc(512, &value_));
+  EXPECT_TRUE(value_ != NULL);

[Scott Hess - ex-Googler, 2014/03/13 22:30:33]

When these succeed, you'll need to free value_.

[kbalazs, 2014/03/18 20:03:54]

Done.

+  EXPECT_FALSE(base::UncheckedMalloc(test_size_, &value_));
+  EXPECT_TRUE(value_ == NULL);
+}
+
+TEST_F(OutOfMemoryDeathTest, UncheckedCalloc) {
+  SetUpInDeathAssert();

[Scott Hess - ex-Googler, 2014/03/13 22:30:33]

Also not a death test?

+  EXPECT_TRUE(base::UncheckedCalloc(1, 512, &value_));
+  EXPECT_TRUE(value_ != NULL);
+  char zero[512];
+  memset(zero, 0, 512);
+  EXPECT_EQ(memcmp(value_, zero, 512), 0);

[Scott Hess - ex-Googler, 2014/03/13 22:30:33]

I think prefer a kConstant to copies of 512.

I think the obvious for() loop would be clearer than crafting a buffer to
memcmp().

[kbalazs, 2014/03/18 20:03:54]

Done.

+
+  EXPECT_FALSE(base::UncheckedCalloc(1, test_size_, &value_));
+  EXPECT_TRUE(value_ == NULL);
+}
+
+#endif