Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 553323002: NaCl: Update revision in DEPS, r13710 -> r13724 (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
Nico, Derek Schuff
CC:
chromium-reviews, bradn, dbrazdil, Derek Schuff, David Yen, Mark Seaborn, native-client-reviews_googlegroups.com, Junichi Uekawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13710 -> r13724 This pulls in the following Native Client changes: r13711: (mseaborn) Move syscall definitions to pure C code, replacing nacl_syscall_handlers_gen.py r13712: (dbrazdil) Fixed signatures of _Unwind_* stubs in PNaCl support library r13713: (uekawa) Minor consistency style fixes. r13714: (dschuff) Move REV file to metadata package and include all repos r13715: (mseaborn) Remove the old "SecureRandom" service, formerly used by get_random_bytes() r13716: (dyen) Unify the way irt_ext libc how tests are declared and defined. r13717: (dyen) Asserts used by irt_ext are now done through error_report.c. r13718: (dschuff) Update revision for PNaCl r13696->r13714 r13719: (dschuff) Build host libc++ and host tools with clang on Linux and Mac r13720: (bradnelson) Switching pnacl download script to use gsutil for download too. r13721: (dyen) In IRT Extension API, added file stat support and tests. r13722: (dbrazdil) Add MinSFI loader r13723: (bradnelson) Vary build settings on fastbuild + configuration + buildtype (reland). r13724: (dbrazdil) Update signature of MinSFI's entry point BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk,linux_chromium_dbg Committed: https://crrev.com/9160b5dcb8937d8d34e9174dc7847ed60b38c05b Cr-Commit-Position: refs/heads/master@{#294264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Mark Seaborn
The test failures here should be resolved by https://chromium.googlesource.com/chromium/src/+/3b1894e3b0e44d01d53afb33b6b0c1b01db5acaf
6 years, 3 months ago (2014-09-10 20:13:51 UTC) #2
Derek Schuff
lgtm
6 years, 3 months ago (2014-09-10 20:22:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/553323002/1
6 years, 3 months ago (2014-09-10 21:02:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10a7f671d54f92e0b427e54dd94f84a8ff3bf531
6 years, 3 months ago (2014-09-10 23:54:53 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9160b5dcb8937d8d34e9174dc7847ed60b38c05b Cr-Commit-Position: refs/heads/master@{#294264}
6 years, 3 months ago (2014-09-11 00:09:12 UTC) #9
Nico
Hi, the win/clang 64 bot started failing after this landed with FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper ...
6 years, 3 months ago (2014-09-11 15:26:09 UTC) #11
Nico
For comparison, here's the regular x64 release bot's output: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/2651/steps/compile/logs/stdio It also uses --target Release_x64, ...
6 years, 3 months ago (2014-09-11 15:31:49 UTC) #12
Nico
…probably r13723, I'll ask on the review of that. Sorry for the noise!
6 years, 3 months ago (2014-09-11 15:34:00 UTC) #13
Nico
6 years, 3 months ago (2014-09-11 15:48:05 UTC) #14
Message was sent while issue was closed.
Since Mark just link to this from elsewhere: I filed
https://code.google.com/p/chromium/issues/detail?id=413266 for the issue caused
by r13723.

Powered by Google App Engine
This is Rietveld 408576698