Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 553313002: [gcc 4.8 build-fix] Remove duplicate line for friend declaration in print_web_view_helper.h (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[gcc 4.8 build-fix] Remove duplicate line for friend declaration in print_web_view_helper.h Compilation on linux using gcc 4.8 toolchain fails for the following duplicate statement. FRIEND_TEST_ALL_PREFIXES(PrintWebViewHelperTest, OnPrintPages): error: ‘printing::PrintWebViewHelperTest_DISABLED_OnPrintPages_Test’ is already a friend of ‘printing::PrintWebViewHelper’ [-Werror] NOTRY=true Committed: https://crrev.com/e17158e079e4e51686d001ac288d9066c1ae310a Cr-Commit-Position: refs/heads/master@{#294122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
vivekg
PTAL, thanks.
6 years, 3 months ago (2014-09-10 03:11:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/553313002/1
6 years, 3 months ago (2014-09-10 04:55:56 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-10 05:55:29 UTC) #5
vivekg
On 2014/09/10 at 05:55:29, vitalybuka wrote: > lgtm thank you!
6 years, 3 months ago (2014-09-10 05:57:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/553313002/1
6 years, 3 months ago (2014-09-10 06:26:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 28246815a21f41e97643e8b182e90674e46c7ad9
6 years, 3 months ago (2014-09-10 06:27:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:34:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e17158e079e4e51686d001ac288d9066c1ae310a
Cr-Commit-Position: refs/heads/master@{#294122}

Powered by Google App Engine
This is Rietveld 408576698