Issue 553303002: Add option page entries in XKB extension manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553303002: Add option page entries in XKB extension manifest. (Closed)

Created:
6 years, 3 months ago by Shu Chen

Modified:
6 years, 3 months ago

Reviewers:
James Su

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add option page entries in XKB extension manifest. BUG=388558 TEST=Verified on linux_chromeos. Committed: https://crrev.com/2f23c5b9b24a1526e526c9712e5f48e2809872f3 Cr-Commit-Position: refs/heads/master@{#294095}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -60 lines)			Patch
	M	chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json	View	1	60 chunks	+120 lines, -60 lines	0 comments	Download

Total messages: 6 (2 generated)

James Su

LGTM. On 2014/09/10 01:41:47, Shu Chen wrote: > mailto:shuchen@chromium.org changed reviewers: > + mailto:suzhe@chromium.org

6 years, 3 months ago (2014-09-10 02:12:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/553303002/20001

6 years, 3 months ago (2014-09-10 02:50:49 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 3e36a7375765dd5215094b7488f0d63ea667746e

6 years, 3 months ago (2014-09-10 03:48:04 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:58:53 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2f23c5b9b24a1526e526c9712e5f48e2809872f3
Cr-Commit-Position: refs/heads/master@{#294095}