content/common/gpu/client/gl_helper_unittest.cc - Issue 553293002: command_buffer: Optimize non-debug path of GLES2DecoderImpl::DoCommands().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper_unittest.cc

Issue 553293002: command_buffer: Optimize non-debug path of GLES2DecoderImpl::DoCommands(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test that relied on "cb_command" using scoped TRACE. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/gl_helper_unittest.cc

diff --git a/content/common/gpu/client/gl_helper_unittest.cc b/content/common/gpu/client/gl_helper_unittest.cc

index 25af9f6b23505a3392ddb605ed429873294d1723..b86716614ed25c6d68d67d3084ee39b07a7469f7 100644

--- a/content/common/gpu/client/gl_helper_unittest.cc

+++ b/content/common/gpu/client/gl_helper_unittest.cc

@@ -118,7 +118,11 @@ class GLHelperTest : public testing::Test {

CHECK(item->GetAsDictionary(&dict));

std::string name;

CHECK(dict->GetString("name", &name));

- (*event_counts)[name]++;

+ std::string trace_type;

+ CHECK(dict->GetString("ph", &trace_type));

+ // Count all except END traces, as they come in BEGIN/END pairs.

+ if (trace_type != "E")

+ (*event_counts)[name]++;

VLOG(1) << "trace name: " << name;

}

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')