IPC::ChannelMojo: Introduce IPC::MojoBootstrap for Windows

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 2069 matching lines @@
   NotificationService::current()->Notify(
       NOTIFICATION_RENDERER_PROCESS_CREATED,
       Source<RenderProcessHost>(this),
       NotificationService::NoDetails());
 
   // Allow Mojo to be setup before the renderer sees any Chrome IPC messages.
   // This way, Mojo can be safely used from the renderer in response to any
   // Chrome IPC message.
   MaybeActivateMojo();
 
+  channel_->OnClientLaunched(child_process_launcher_->GetHandle());

[viettrungluu, 2014/09/15 20:19:43]

It feels a bit suboptimal to require an extra explicit call....

I wonder since the listener already get a process ID back (in
OnChannelConnected), we couldn't just use that (and OpenProcess) to get a handle
to the child there....

[Hajime Morrita, 2014/09/15 22:01:36]

Yeah...
I tried that but it didn't work.
A handle returned from OpenProcess() is different from one that 
is returned from CreateProcess(), and DuplicateHandle() call with that 
handle declines the request saying "access denied" :-/

[viettrungluu, 2014/09/15 22:37:27]

I was afraid of something like that.

This design still seems a bit odd and fragile to me. (E.g., are there other
places where we launch processes, where we don't call OnClientLaunched()?
Obviously, this doesn't affect us now, but it could be a source of problems in
the future.)

Unfortunately, I don't really have any idea that's much better (short of much
bigger refactoring). Maybe darin or jam might have some good ideas?

+
   while (!queued_messages_.empty()) {
     Send(queued_messages_.front());
     queued_messages_.pop();
   }
 
 #if defined(ENABLE_WEBRTC)
   if (WebRTCInternals::GetInstance()->aec_dump_enabled())
     EnableAecDump(WebRTCInternals::GetInstance()->aec_dump_file_path());
 #endif
 }
@@ skipping 125 matching lines @@
   if (worker_ref_count_ == 0)
     Cleanup();
 }
 
 void RenderProcessHostImpl::EnsureMojoActivated() {
   mojo_activation_required_ = true;
   MaybeActivateMojo();
 }
 
 }  // namespace content