Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Fix bool vs BOOL. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_keybinding_apitest.cc
diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc
index 215a6103261e164649d695ca430a2ee39b1b591e..020e7266591ba2b630c8ba23dd8bf101441cd816 100644
--- a/chrome/browser/extensions/extension_keybinding_apitest.cc
+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc
@@ -731,4 +731,30 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, ContinuePropagation) {
ASSERT_TRUE(catcher.GetNextResult());
}
+// Test is only applicable on Chrome OS.
+#if defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(CommandsApiTest, ChromeOSConversions) {
+ // Setup the environment.
+ ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
+ ASSERT_TRUE(RunExtensionTest("keybinding/chromeos_conversions")) << message_;
+ ui_test_utils::NavigateToURL(
+ browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+
+ ResultCatcher catcher;
+
+ // Send all expected keys.
+ ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
+ browser(), ui::VKEY_LEFT, false, true, false, true));
+ ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
+ browser(), ui::VKEY_UP, false, true, false, true));
+ ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
+ browser(), ui::VKEY_RIGHT, false, true, false, true));
+ ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
+ browser(), ui::VKEY_DOWN, false, true, false, true));
+
+ ASSERT_TRUE(catcher.GetNextResult());
+}
+#endif // OS_CHROMEOS
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698