Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/browser/extensions/extension_commands_global_registry.h

Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Address more comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_commands_global_registry.h
diff --git a/chrome/browser/extensions/extension_commands_global_registry.h b/chrome/browser/extensions/extension_commands_global_registry.h
index 92a7a8e42b4073ab50a7802fea22dc99b01f798e..61e9af2920f816ac0e3ff362f0182db2b5c30530 100644
--- a/chrome/browser/extensions/extension_commands_global_registry.h
+++ b/chrome/browser/extensions/extension_commands_global_registry.h
@@ -33,6 +33,12 @@ class ExtensionCommandsGlobalRegistry
public ExtensionKeybindingRegistry,
public GlobalShortcutListener::Observer {
public:
+ ExtensionKeybindingRegistry* active_registry() { return active_registry_; }
+
+ void set_active_registry(ExtensionKeybindingRegistry* registry) {
+ active_registry_ = registry;
+ }
+
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<ExtensionCommandsGlobalRegistry>*
GetFactoryInstance();
@@ -70,6 +76,9 @@ class ExtensionCommandsGlobalRegistry
// Weak pointer to our browser context. Not owned by us.
content::BrowserContext* browser_context_;
+ // The active ExtensionKeybindingRegistry.
Devlin 2014/09/12 00:10:33 I might be a bit more specific here and say someth
David Tseng 2014/09/12 01:26:58 Done (the comment part).
Finnur 2014/09/12 11:25:44 Rather than if-def'ing I'm actually more intereste
+ ExtensionKeybindingRegistry* active_registry_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionCommandsGlobalRegistry);
};

Powered by Google App Engine
This is Rietveld 408576698