Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.

chrome/browser/ui/views/toolbar/browser_actions_container.h

Index: chrome/browser/ui/views/toolbar/browser_actions_container.h
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.h b/chrome/browser/ui/views/toolbar/browser_actions_container.h
index f3702c5aa560c5c1824198a68836a2d4c9d4e201..e9a9dbf61f00eafbaff663f7f6dd5bd39ea6b505 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.h
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.h
@@ -9,6 +9,7 @@
 #include "chrome/browser/extensions/extension_keybinding_registry.h"
 #include "chrome/browser/extensions/extension_toolbar_model.h"
 #include "chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h"
+#include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"

[Devlin, 2014/09/11 21:38:13]

Shouldn't need to include this.

[David Tseng, 2014/09/11 23:57:09]

I actually do due to the accesser which calls
extension_keybinding_registry.get(); it's also a toss up whether that's still
considered a trivial accesser (and therefore qualifies for the unix style
naming).

[Devlin, 2014/09/12 00:10:33]

A forward-declaration is sufficient, because you don't need to know any
information about the type for the get() command - get() is actually a method of
the scoped pointer (and is perfectly trivial for a unix_hacker_style accesssor).

Though, since you brought it up, this probably *should* #include
base/memory/scoped_ptr.h

[David Tseng, 2014/09/12 01:07:14]

I misspoke perhaps, but the cast to ExtensionKeybindingRegistry does require the
header...I could return an ExtensionKeybindingsViews, but then would need to up
cast everywhere I'm trying to set.

 #include "chrome/browser/ui/views/toolbar/browser_action_view.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/animation/tween.h"
@@ -18,7 +19,6 @@
 #include "ui/views/view.h"
 
 class BrowserActionsContainerObserver;
-class ExtensionKeybindingRegistryViews;
 class ExtensionPopup;
 
 namespace extensions {
@@ -154,6 +154,11 @@ class BrowserActionsContainer
   // Returns the profile this container is associated with.
   Profile* profile() const { return profile_; }
 
+  // The class that registers for keyboard shortcuts for extension commands.
+  extensions::ExtensionKeybindingRegistry* extension_keybinding_registry() {
+    return extension_keybinding_registry_.get();
+  }
+
   // Get a particular browser action view.
   BrowserActionView* GetBrowserActionViewAt(int index) {
     return browser_action_views_[index];