chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/manifest.json - Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/manifest.json

Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Address sky's comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/toolbar/browser_actions_container.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/background.js ('k') | ui/aura/test/ui_controls_factory_aurax11.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "An extension to test shortcuts propagation",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "background": {

	6 "scripts": ["background.js"]

	7 },

	8 "permissions": [ "tabs" ],

	9 "commands": {

	10 "Search-Shift-Left": {

	11 "description": "Test non-conversion of this key",

	12 "suggested_key": {

	13 "chromeos": "Search+Shift+Left"

	14 }

	15 },

	16 "Search-Shift-Up": {
	Devlin 2014/09/11 18:41:01 nit: indentation nit: indentation David Tseng 2014/09/11 19:34:20 Done. Show quoted text On 2014/09/11 18:41:01, Devlin wrote: > nit: indentation Done.
	17 "description": "Test non-conversion of this key",

	18 "suggested_key": {

	19 "chromeos": "Search+Shift+Up"

	20 }

	21 },

	22 "Search-Shift-Right": {

	23 "description": "Test non-conversion of this key",

	24 "suggested_key": {

	25 "chromeos": "Search+Shift+Right"

	26 }

	27 },

	28 "Search-Shift-Down": {

	29 "description": "Test non-conversion of this key",

	30 "suggested_key": {

	31 "chromeos": "Search+Shift+Down"

	32 }

	33 }

	34 }

	35 }

OLD	NEW