chrome/browser/ui/views/toolbar/browser_actions_container.h - Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/toolbar/browser_actions_container.h

Issue 553243002: Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Address sky's comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_keybinding_registry_tracker.h ('K') | « chrome/browser/extensions/extension_keybinding_registry_tracker.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	Devlin 2014/09/11 18:41:01 nit: These, on the other hand, _shouldn't_ be upda nit: These, on the other hand, _shouldn't_ be updated. David Tseng 2014/09/11 19:34:20 Done. Show quoted text On 2014/09/11 18:41:01, Devlin wrote: > nit: These, on the other hand, _shouldn't_ be updated. Done.
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_

6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_	6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_

7	7

8 #include "base/observer_list.h"	8 #include "base/observer_list.h"

9 #include "chrome/browser/extensions/extension_keybinding_registry.h"	9 #include "chrome/browser/extensions/extension_keybinding_registry.h"

10 #include "chrome/browser/extensions/extension_toolbar_model.h"	10 #include "chrome/browser/extensions/extension_toolbar_model.h"

11 #include "chrome/browser/ui/views/extensions/browser_action_overflow_menu_contro ller.h"	11 #include "chrome/browser/ui/views/extensions/browser_action_overflow_menu_contro ller.h"

(...skipping 405 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
417	417

418 // Handles delayed showing of the overflow menu when hovering.	418 // Handles delayed showing of the overflow menu when hovering.

419 base::WeakPtrFactory<BrowserActionsContainer> show_menu_task_factory_;	419 base::WeakPtrFactory<BrowserActionsContainer> show_menu_task_factory_;

420	420

421 ObserverList<BrowserActionsContainerObserver> observers_;	421 ObserverList<BrowserActionsContainerObserver> observers_;

422	422

423 DISALLOW_COPY_AND_ASSIGN(BrowserActionsContainer);	423 DISALLOW_COPY_AND_ASSIGN(BrowserActionsContainer);

424 };	424 };

425	425

426 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_	426 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTIONS_CONTAINER_H_

OLD	NEW