Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/browser_close_manager.h"
 #include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/translate/core/common/translate_errors.h"
+#include "ui/base/accelerators/accelerator.h"
 #include "ui/base/base_window.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Browser;
 class BrowserWindowTesting;
 class DownloadShelf;
 class FindBar;
 class GURL;
 class LocationBar;
@@ skipping 366 matching lines @@
 
   // Returns the height inset for RenderView when detached bookmark bar is
   // shown.  Invoked when a new RenderHostView is created for a non-NTP
   // navigation entry and the bookmark bar is detached.
   virtual int GetRenderViewHeightInsetWithDetachedBookmarkBar() = 0;
 
   // Executes |command| registered by |extension|.
   virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
                                        const extensions::Command& command) = 0;
 
+  // Returns whether the given |accelerator| is registered by an extension.
+  virtual bool IsExtensionCommandRegistered(

[sky, 2014/09/10 23:55:14]

This feels like something profile specific, and not per browser window. It seems
like you've wired it this way as ExtensionKeybindingRegistry is created per
window. Is there some other way to get this information through the profile?

[David Tseng, 2014/09/11 00:05:25]

In the case of global commands, the registry is associated with a profile.
Unfortunately, the non-global registry lives in a window, so I don't think
there's any other way to get at the owner (BrowserView -> ToolbarView ->
BrowserActionsContainer). If there's some other way of getting a
BrowserActionsContainer based on a profile or BrowserContext, I'd be happy to do
that, but I don't think that's available.

 @finnur, why was the non-global registry placed in BrowserActionsContainer?

[Finnur, 2014/09/11 09:51:58]

It has been quite a while, but as I recall it is because it has the same
lifetime as the BrowserActionsContainer, is conceptually related to it (the BAC
shows extensions and the Registry is handling shortcuts for them). And it also
needs access to the focus manager for that window in order to register
accelerators.

I do have an urge to loop in Devlin, though, as he's been revamping this area
and may have good ideas.

+      const ui::Accelerator& accelerator) = 0;
+
  protected:
   friend class BrowserCloseManager;
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_