Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.

chrome/browser/ui/views/toolbar/toolbar_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/i18n/number_formatting.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/command_updater.h"
+#include "chrome/browser/extensions/extension_commands_global_registry.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_command_controller.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
 #include "chrome/browser/ui/browser_instant_controller.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 237 matching lines @@
     back_->SetTooltipText(
         l10n_util::GetStringUTF16(IDS_ACCNAME_TOOLTIP_BACK));
     forward_->SetTooltipText(
         l10n_util::GetStringUTF16(IDS_ACCNAME_TOOLTIP_FORWARD));
   }
 }
 
 void ToolbarView::OnWidgetVisibilityChanged(views::Widget* widget,
                                             bool visible) {
   // Safe to call multiple times; the bubble will only appear once.
-  if (visible)
+  if (visible) {
     extension_message_bubble_factory_->MaybeShow(app_menu_);
+    extensions::ExtensionCommandsGlobalRegistry::Get(browser_->profile())

[Devlin, 2014/09/11 21:38:13]

We also need to unset this, either in ToolbarView or BrowserActionsContainer,
when the BrowserActionsContainer gets destroyed.  It would probably make the
most sense to do in a OnWidgetDestroyed() method.

[Devlin, 2014/09/11 21:40:00]

And also when activation is lost, and not necessarily sent to another window
with a toolbar (like, e.g., an app window).  So also just an else clause to this
part.

[David Tseng, 2014/09/11 23:57:09]

That's what I considered originally...but are we guaranteed this widget looses
visibility before the new widget gains/is notified of its visibility change?

[David Tseng, 2014/09/11 23:57:09]

Yeah, I wasn't sure about this one. Will add to OnWidgetDestroyed.

[Devlin, 2014/09/12 00:10:33]

Sky knows best here, so I definitely defer to him. :)  But a cursory look
through the code implied that no, we won't get a visibility change prior to a
deletion (so we need OnWidgetDestroyed()).

+        ->set_active_registry(
+            browser_actions_->extension_keybinding_registry());
+  }
 }
 
 void ToolbarView::Update(WebContents* tab) {
   if (location_bar_)
     location_bar_->Update(tab);
   if (browser_actions_)
     browser_actions_->RefreshBrowserActionViews();
   if (reload_)
     reload_->set_menu_enabled(chrome::IsDebuggerAttachedToCurrentTab(browser_));
 }
@@ skipping 480 matching lines @@
 
 void ToolbarView::OnShowHomeButtonChanged() {
   Layout();
   SchedulePaint();
 }
 
 int ToolbarView::content_shadow_height() const {
   return browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH ?
       kContentShadowHeightAsh : kContentShadowHeight;
 }