Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 553233006: Added XMLExternalResourceLoaded to WebCore.FeatureObserver in histograms.xml. (Closed)

Created:
6 years, 3 months ago by tasak
Modified:
6 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added XMLExternalResourceLoaded to WebCore.FeatureObserver in histograms.xml. To deprecate loading external resources in XML, e.g. external DTDs, measure its usage. BUG= Committed: https://crrev.com/336ca4d58481f5545910325187b273120b0247e1 Cr-Commit-Position: refs/heads/master@{#294402}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tasak
Would you review this CL? I have already updated third_party/WebKit/Source/core/frame/UseCounter.h: https://codereview.chromium.org/552673002/ https://src.chromium.org/viewvc/blink?view=rev&revision=181602
6 years, 3 months ago (2014-09-10 09:37:28 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/553233006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/553233006/diff/1/tools/metrics/histograms/histograms.xml#oldcode42305 tools/metrics/histograms/histograms.xml:42305: <int value="524" label="SrcsetWDescriptor"/> Would you mind also adding the ...
6 years, 3 months ago (2014-09-10 13:41:00 UTC) #3
tasak
Thank you for reviewing. https://codereview.chromium.org/553233006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/553233006/diff/1/tools/metrics/histograms/histograms.xml#oldcode42305 tools/metrics/histograms/histograms.xml:42305: <int value="524" label="SrcsetWDescriptor"/> On 2014/09/10 ...
6 years, 3 months ago (2014-09-11 05:49:51 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-11 15:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553233006/20001
6 years, 3 months ago (2014-09-11 15:37:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a3fd4c43df93532c24240b4c84f16b9c4c3571ad
6 years, 3 months ago (2014-09-11 16:41:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 16:47:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/336ca4d58481f5545910325187b273120b0247e1
Cr-Commit-Position: refs/heads/master@{#294402}

Powered by Google App Engine
This is Rietveld 408576698