chrome/browser/safe_browsing/database_manager_unittest.cc - Issue 55323002: Fix tests that were setting safebrowsing factories without unsetting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/database_manager_unittest.cc

Issue 55323002: Fix tests that were setting safebrowsing factories without unsetting them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review changes Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/database_manager_unittest.cc

diff --git a/chrome/browser/safe_browsing/database_manager_unittest.cc b/chrome/browser/safe_browsing/database_manager_unittest.cc

index 9c425a60087943e37b195c9bcd2a19dfc07168d6..192c6926850e266542bb6e1fc2d944a5d17ae105 100644

--- a/chrome/browser/safe_browsing/database_manager_unittest.cc

+++ b/chrome/browser/safe_browsing/database_manager_unittest.cc

@@ -39,10 +39,16 @@ class TestSafeBrowsingServiceFactory : public SafeBrowsingServiceFactory {

class SafeBrowsingDatabaseManagerTest : public PlatformTest {

public:

- virtual void SetUp() {

+ virtual void SetUp() OVERRIDE {

PlatformTest::SetUp();

SafeBrowsingService::RegisterFactory(&factory_);

}

+ virtual void TearDown() OVERRIDE {

+ SafeBrowsingService::RegisterFactory(NULL);

+ PlatformTest::TearDown();

+ }

bool RunSBHashTest(const safe_browsing_util::ListType list_type,

const std::vector<SBThreatType>& expected_threats,

const std::string& result_list);