Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2857)

Unified Diff: chrome/browser/safe_browsing/database_manager_unittest.cc

Issue 55323002: Fix tests that were setting safebrowsing factories without unsetting them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/database_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/database_manager_unittest.cc b/chrome/browser/safe_browsing/database_manager_unittest.cc
index 9c425a60087943e37b195c9bcd2a19dfc07168d6..c32409beefae54dd7bc2caccb56e2321fc35dc77 100644
--- a/chrome/browser/safe_browsing/database_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/database_manager_unittest.cc
@@ -39,10 +39,15 @@ class TestSafeBrowsingServiceFactory : public SafeBrowsingServiceFactory {
class SafeBrowsingDatabaseManagerTest : public PlatformTest {
public:
- virtual void SetUp() {
+ virtual void SetUp() OVERRIDE {
PlatformTest::SetUp();
SafeBrowsingService::RegisterFactory(&factory_);
}
+
+ virtual void TearDown() OVERRIDE {
+ SafeBrowsingService::RegisterFactory(NULL);
Scott Hess - ex-Googler 2013/10/31 22:07:20 PlatformTest::TearDown() after.
mattm 2013/10/31 22:39:23 Oops, Done.
+ }
+
bool RunSBHashTest(const safe_browsing_util::ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::string& result_list);

Powered by Google App Engine
This is Rietveld 408576698