Use ScopedEVP_PKEY in keystore_openssl.cc.

Use ScopedEVP_PKEY in keystore_openssl.cc.

Somewhat cleaner without having to pass around half-constructed EVP_PKEY
objects everywhere.

BUG=none

Committed: https://crrev.com/2a463aa5cfadb60605e7d63cd00af8fd7ffbadf7
Cr-Commit-Position: refs/heads/master@{#294241}

[davidben, 2014-09-09 23:07:19]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2014-09-09 23:07:19]

https://codereview.chromium.org/553223002/diff/1/net/android/keystore_openssl.cc
File net/android/keystore_openssl.cc (right):

https://codereview.chromium.org/553223002/diff/1/net/android/keystore_openssl...
net/android/keystore_openssl.cc:348: !EVP_PKEY_set1_RSA(pkey.get(), rsa.get()))
{
It doesn't really matter because EVP_PKEY_set1_RSA can't fail anyway, but it
does have a return value and the EVP_PKEY_assign_RSA version has this awkward
property that it takes ownership of its argument only if it succeeds.

[Ryan Sleevi, 2014-09-09 23:23:17]

lgtm

[davidben, 2014-09-10 21:01:14]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:02:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/553223002/1

[commit-bot: I haz the power, 2014-09-10 22:14:21]

Committed patchset #1 (id:1) as 9f70a9f84eebef18b42af410a80e72e51cac3e01

[commit-bot: I haz the power, 2014-09-10 22:26:25]

Patchset 1 (id:??) landed as
https://crrev.com/2a463aa5cfadb60605e7d63cd00af8fd7ffbadf7
Cr-Commit-Position: refs/heads/master@{#294241}