content/browser/compositor/test/no_transport_image_transport_factory.h - Issue 553213003: Avoid destroying surface before the parent surface stops referencing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/test/no_transport_image_transport_factory.h

Issue 553213003: Avoid destroying surface before the parent surface stops referencing it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/surface_display_output_surface.cc ('k') | content/browser/compositor/test/no_transport_image_transport_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/test/no_transport_image_transport_factory.h

diff --git a/content/browser/compositor/test/no_transport_image_transport_factory.h b/content/browser/compositor/test/no_transport_image_transport_factory.h

index 6bcca6fd25a9907eca58ea0182cae97e10dcd2b3..67ba4ecd4dc43fe1199c6787ebf90bc2a037cb53 100644

--- a/content/browser/compositor/test/no_transport_image_transport_factory.h

+++ b/content/browser/compositor/test/no_transport_image_transport_factory.h

@@ -24,8 +24,6 @@ class NoTransportImageTransportFactory : public ImageTransportFactory {

// ImageTransportFactory implementation.

virtual ui::ContextFactory* GetContextFactory() override;

virtual gfx::GLSurfaceHandle GetSharedSurfaceHandle() override;

- virtual scoped_ptr<cc::SurfaceIdAllocator> CreateSurfaceIdAllocator()

- override;

virtual cc::SurfaceManager* GetSurfaceManager() override;

virtual GLHelper* GetGLHelper() override;

virtual void AddObserver(ImageTransportFactoryObserver* observer) override;

@@ -38,6 +36,7 @@ class NoTransportImageTransportFactory : public ImageTransportFactory {

scoped_ptr<ui::ContextFactory> context_factory_;

scoped_refptr<cc::ContextProvider> context_provider_;

scoped_ptr<GLHelper> gl_helper_;

+ scoped_ptr<cc::SurfaceManager> surface_manager_;

ObserverList<ImageTransportFactoryObserver> observer_list_;

DISALLOW_COPY_AND_ASSIGN(NoTransportImageTransportFactory);